feat: Interactive notifications, Like/Dislike shortcuts, and Autoplay fixes #4137
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit f5175a6.
This commit integrates changes proposed by @CalG24 in issue pear-devs#922 to enhance desktop integration and fix playback issues. Changes include: 1. Interactive Notifications (Windows): - Added interactive buttons to toast notifications: Like, Dislike, Previous, Play/Pause, and Next. - Implemented state awareness so notification icons (filled vs outline) reflect the actual song status. - Added logic to refresh notifications on interaction rather than dismissing them. 2. Shortcuts: - Added support for 'Like' and 'Dislike' in global and local shortcuts. - Added a global shortcut tracker to handle state changes and trigger notifications appropriately. 3. Autoplay & Startup Fixes: - Implemented a `globalHasAppliedOnce` flag in the disable-autoplay plugin to prevent audio "blasts" on startup. - Added early muting/pausing logic in the renderer to catch audio streams before plugin initialization. - Improved queue management to ensure subsequent videos play automatically after the initial pause. 4. Localization: - Added translation strings for "Like" and "Dislike" across all supported languages. > I am providing this code on behalf of CalG24
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR implements several features and fixes provided by @CalG24 as discussed in issue #922.
Disclaimer: I am submitting this code on behalf of the original author to facilitate the contribution process. I have packaged their changes into this commit but have not personally tested or reviewed the implementation logic.
Changes
1. Interactive Notifications (Windows)
2. Global & Local Shortcuts
likeanddislikeactions via global and local shortcuts.3. Autoplay / Startup Fixes
globalHasAppliedOnceflag to track if the pause has been applied globally.4. Localization (i18n)
"like"and"dislike"translation strings to all supported language files.Notes on this submission