feat: Add Better Fullscreen plugin #4138

noobpro45 · 2025-12-09T21:41:03Z

Added a new "Better Fullscreen" plugin that provides animated background visuals and synced lyrics.

Features:

Animated background blobs based on album art colors.
Synced lyrics with Perfect Sync offset support.
Button added to album art/player to trigger fullscreen mode.

github-actions

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

eslint

🚫 [eslint] <prettier/prettier> _{reported by reviewdog 🐶}
Replace if with ·if·

pear-desktop/src/plugins/better-fullscreen/index.ts

Line 181 in 0164e40

if(title && artist && video) {

🚫 [eslint] <prettier/prettier> _{reported by reviewdog 🐶}
Replace ···············ui.lines!.innerHTML·= with ················ui.lines!.innerHTML·=⏎·················

pear-desktop/src/plugins/better-fullscreen/index.ts

Line 182 in 0164e40

ui.lines!.innerHTML = '<div class="bfs-empty">Searching...</div>';

🚫 [eslint] <prettier/prettier> _{reported by reviewdog 🐶}
Insert ·

pear-desktop/src/plugins/better-fullscreen/index.ts

Line 183 in 0164e40

performFetch(title, artist, video.duration);

🚫 [eslint] <prettier/prettier> _{reported by reviewdog 🐶}
Insert ·

pear-desktop/src/plugins/better-fullscreen/index.ts

Line 184 in 0164e40

}

🚫 [eslint] <prettier/prettier> _{reported by reviewdog 🐶}
Insert ··

pear-desktop/src/plugins/better-fullscreen/index.ts

Line 185 in 0164e40

});

🚫 [eslint] <prettier/prettier> _{reported by reviewdog 🐶}
Delete ············

pear-desktop/src/plugins/better-fullscreen/index.ts

Line 193 in 0164e40

🚫 [eslint] <prettier/prettier> _{reported by reviewdog 🐶}
Replace ·line.text.includes('...')·||·line.text.includes('♪')·|| with ⏎··············line.text.includes('...')·||⏎··············line.text.includes('♪')·||⏎·············

pear-desktop/src/plugins/better-fullscreen/index.ts

Line 194 in 0164e40

    
           const isInst = line.text.includes('...') || line.text.includes('♪') || line.text.toLowerCase().includes('instrumental');

🚫 [eslint] <prettier/prettier> _{reported by reviewdog 🐶}
Delete ············

pear-desktop/src/plugins/better-fullscreen/index.ts

Line 195 in 0164e40

🚫 [eslint] <prettier/prettier> _{reported by reviewdog 🐶}
Insert ·

pear-desktop/src/plugins/better-fullscreen/index.ts

Line 196 in 0164e40

if(isInst) {

🚫 [eslint] <prettier/prettier> _{reported by reviewdog 🐶}
Delete ··

pear-desktop/src/plugins/better-fullscreen/index.ts

Line 197 in 0164e40

el.classList.add('instrumental');

🚫 [eslint] <prettier/prettier> _{reported by reviewdog 🐶}
Delete ··

pear-desktop/src/plugins/better-fullscreen/index.ts

Line 198 in 0164e40

el.innerHTML = `

🚫 [eslint] <prettier/prettier> _{reported by reviewdog 🐶}
Delete ·

pear-desktop/src/plugins/better-fullscreen/index.ts

Line 203 in 0164e40

</div>`;

🚫 [eslint] <prettier/prettier> _{reported by reviewdog 🐶}
Delete ··

pear-desktop/src/plugins/better-fullscreen/index.ts

Line 205 in 0164e40

let html = `<span>${line.text}</span>`;

🚫 [eslint] <prettier/prettier> _{reported by reviewdog 🐶}
Replace ··if with if·

pear-desktop/src/plugins/better-fullscreen/index.ts

Line 206 in 0164e40

if(line.romaji) {

🚫 [eslint] <prettier/prettier> _{reported by reviewdog 🐶}
Delete ····

pear-desktop/src/plugins/better-fullscreen/index.ts

Line 207 in 0164e40

html += `<span class="bfs-romaji">${line.romaji}</span>`;

🚫 [eslint] <prettier/prettier> _{reported by reviewdog 🐶}
Replace ················ with ··············

pear-desktop/src/plugins/better-fullscreen/index.ts

Line 208 in 0164e40

}

🚫 [eslint] <prettier/prettier> _{reported by reviewdog 🐶}
Delete ··

pear-desktop/src/plugins/better-fullscreen/index.ts

Line 209 in 0164e40

el.innerHTML = html;

🚫 [eslint] <prettier/prettier> _{reported by reviewdog 🐶}
Delete ············

pear-desktop/src/plugins/better-fullscreen/index.ts

Line 211 in 0164e40

🚫 [eslint] <prettier/prettier> _{reported by reviewdog 🐶}
Delete ········

pear-desktop/src/plugins/better-fullscreen/index.ts

Line 225 in 0164e40

🚫 [eslint] <@typescript-eslint/no-unsafe-member-access> _{reported by reviewdog 🐶}
Unsafe member access .perfectSync on an any value.

pear-desktop/src/plugins/better-fullscreen/index.ts

Line 226 in 0164e40

const offset = config.perfectSync ? 0.5 : 0;

🚫 [eslint] <prettier/prettier> _{reported by reviewdog 🐶}
Delete ·

pear-desktop/src/plugins/better-fullscreen/index.ts

Line 227 in 0164e40

const timeMs = (time + offset) * 1000;

🚫 [eslint] <prettier/prettier> _{reported by reviewdog 🐶}
Delete ········

pear-desktop/src/plugins/better-fullscreen/index.ts

Line 228 in 0164e40

🚫 [eslint] <prettier/prettier> _{reported by reviewdog 🐶}
Delete ········

pear-desktop/src/plugins/better-fullscreen/index.ts

Line 234 in 0164e40

🚫 [eslint] <@typescript-eslint/no-explicit-any> _{reported by reviewdog 🐶}
Unexpected any. Specify a different type.

pear-desktop/src/plugins/better-fullscreen/index.ts

Line 238 in 0164e40

domLines.forEach((line: any, idx) => {

🚫 [eslint] <@typescript-eslint/no-unsafe-call> _{reported by reviewdog 🐶}
Unsafe call of a(n) any typed value.

pear-desktop/src/plugins/better-fullscreen/index.ts

Line 240 in 0164e40

if (!line.classList.contains('active')) {

🚫 [eslint] <@typescript-eslint/no-unsafe-member-access> _{reported by reviewdog 🐶}
Unsafe member access .classList on an any value.

pear-desktop/src/plugins/better-fullscreen/index.ts

Line 240 in 0164e40

if (!line.classList.contains('active')) {

🚫 [eslint] <@typescript-eslint/no-unsafe-call> _{reported by reviewdog 🐶}
Unsafe call of a(n) any typed value.

pear-desktop/src/plugins/better-fullscreen/index.ts

Line 241 in 0164e40

line.classList.add('active');

🚫 [eslint] <@typescript-eslint/no-unsafe-member-access> _{reported by reviewdog 🐶}
Unsafe member access .classList on an any value.

pear-desktop/src/plugins/better-fullscreen/index.ts

Line 241 in 0164e40

line.classList.add('active');

🚫 [eslint] <@typescript-eslint/no-unsafe-call> _{reported by reviewdog 🐶}
Unsafe call of a(n) any typed value.

pear-desktop/src/plugins/better-fullscreen/index.ts

Line 242 in 0164e40

line.scrollIntoView({ behavior: 'smooth', block: 'center' });

🚫 [eslint] <@typescript-eslint/no-unsafe-member-access> _{reported by reviewdog 🐶}
Unsafe member access .scrollIntoView on an any value.

pear-desktop/src/plugins/better-fullscreen/index.ts

Line 242 in 0164e40

line.scrollIntoView({ behavior: 'smooth', block: 'center' });

🚫 [eslint] <prettier/prettier> _{reported by reviewdog 🐶}
Insert ·

pear-desktop/src/plugins/better-fullscreen/index.ts

Line 244 in 0164e40

if(line.classList.contains('instrumental')) isInstrumental = true;

🚫 [eslint] <@typescript-eslint/no-unsafe-call> _{reported by reviewdog 🐶}
Unsafe call of a(n) any typed value.

pear-desktop/src/plugins/better-fullscreen/index.ts

Line 244 in 0164e40

if(line.classList.contains('instrumental')) isInstrumental = true;

🚫 [eslint] <@typescript-eslint/no-unsafe-member-access> _{reported by reviewdog 🐶}
Unsafe member access .classList on an any value.

pear-desktop/src/plugins/better-fullscreen/index.ts

Line 244 in 0164e40

if(line.classList.contains('instrumental')) isInstrumental = true;

🚫 [eslint] <@typescript-eslint/no-unsafe-call> _{reported by reviewdog 🐶}
Unsafe call of a(n) any typed value.

pear-desktop/src/plugins/better-fullscreen/index.ts

Line 246 in 0164e40

line.classList.remove('active');

🚫 [eslint] <@typescript-eslint/no-unsafe-member-access> _{reported by reviewdog 🐶}
Unsafe member access .classList on an any value.

pear-desktop/src/plugins/better-fullscreen/index.ts

Line 246 in 0164e40

line.classList.remove('active');

🚫 [eslint] <prettier/prettier> _{reported by reviewdog 🐶}
Insert ·

pear-desktop/src/plugins/better-fullscreen/index.ts

Line 250 in 0164e40

if(isInstrumental) ui.viz?.classList.add('show');

🚫 [eslint] <prettier/prettier> _{reported by reviewdog 🐶}
Replace title:·string,·artist:·string,·duration:·number with ⏎········title:·string,⏎········artist:·string,⏎········duration:·number,⏎······

pear-desktop/src/plugins/better-fullscreen/index.ts

Line 254 in 0164e40

    
           const performFetch = async (title: string, artist: string, duration: number) => {

🚫 [eslint] <prettier/prettier> _{reported by reviewdog 🐶}
Delete ·

pear-desktop/src/plugins/better-fullscreen/index.ts

Line 255 in 0164e40

lyrics = await getLyrics(title, artist, duration, config.romanize);

🚫 [eslint] <@typescript-eslint/no-unsafe-argument> _{reported by reviewdog 🐶}
Unsafe argument of type any assigned to a parameter of type boolean.

pear-desktop/src/plugins/better-fullscreen/index.ts

Line 255 in 0164e40

lyrics = await getLyrics(title, artist, duration, config.romanize);

🚫 [eslint] <@typescript-eslint/no-unsafe-member-access> _{reported by reviewdog 🐶}
Unsafe member access .romanize on an any value.

pear-desktop/src/plugins/better-fullscreen/index.ts

Line 255 in 0164e40

lyrics = await getLyrics(title, artist, duration, config.romanize);

🚫 [eslint] <prettier/prettier> _{reported by reviewdog 🐶}
Delete ·

pear-desktop/src/plugins/better-fullscreen/index.ts

Line 256 in 0164e40

renderLyrics();

🚫 [eslint] <prettier/prettier> _{reported by reviewdog 🐶}
Replace "0:00" with '0:00'

pear-desktop/src/plugins/better-fullscreen/index.ts

Line 260 in 0164e40

if (isNaN(s)) return "0:00";

🚫 [eslint] <stylistic/quotes> _{reported by reviewdog 🐶}
Strings must use singlequote.

pear-desktop/src/plugins/better-fullscreen/index.ts

Line 260 in 0164e40

if (isNaN(s)) return "0:00";

🚫 [eslint] <@typescript-eslint/require-await> _{reported by reviewdog 🐶}
Async arrow function has no 'await' expression.

pear-desktop/src/plugins/better-fullscreen/index.ts

Line 266 in 0164e40

setInterval(async () => {

🚫 [eslint] <prettier/prettier> _{reported by reviewdog 🐶}
Replace document.querySelector('ytmusic-player-bar·.title')·as·HTMLElement with ⏎··········document.querySelector('ytmusic-player-bar·.title')·as·HTMLElement⏎········

pear-desktop/src/plugins/better-fullscreen/index.ts

Line 270 in 0164e40

    
           const title = (document.querySelector('ytmusic-player-bar .title') as HTMLElement)?.innerText;

🚫 [eslint] <prettier/prettier> _{reported by reviewdog 🐶}
Replace document.querySelector('ytmusic-player-bar·.byline')·as·HTMLElement with ⏎··········document.querySelector('ytmusic-player-bar·.byline')·as·HTMLElement⏎········

pear-desktop/src/plugins/better-fullscreen/index.ts

Line 271 in 0164e40

    
           let artist = (document.querySelector('ytmusic-player-bar .byline') as HTMLElement)?.innerText;

🚫 [eslint] <prettier/prettier> _{reported by reviewdog 🐶}
Replace document.querySelector('.image.ytmusic-player-bar')·as·HTMLImageElement with ⏎··········document.querySelector(⏎············'.image.ytmusic-player-bar',⏎··········)·as·HTMLImageElement⏎········

pear-desktop/src/plugins/better-fullscreen/index.ts

Line 272 in 0164e40

    
           const artSrc = (document.querySelector('.image.ytmusic-player-bar') as HTMLImageElement)?.src;

🚫 [eslint] <prettier/prettier> _{reported by reviewdog 🐶}
Insert ·

pear-desktop/src/plugins/better-fullscreen/index.ts

Line 273 in 0164e40

if(artist) artist = artist.split(/[•·]/)[0].trim();

🚫 [eslint] <prettier/prettier> _{reported by reviewdog 🐶}
Delete ·

pear-desktop/src/plugins/better-fullscreen/index.ts

Line 279 in 0164e40

const highRes = artSrc.replace(/w\d+-h\d+/, 'w1200-h1200');

🚫 [eslint] <prettier/prettier> _{reported by reviewdog 🐶}
Delete ·

pear-desktop/src/plugins/better-fullscreen/index.ts

Line 280 in 0164e40

if (ui.art.src !== highRes) {

🚫 [eslint] <prettier/prettier> _{reported by reviewdog 🐶}
Delete ·

pear-desktop/src/plugins/better-fullscreen/index.ts

Line 281 in 0164e40

ui.art.src = highRes;

🚫 [eslint] <prettier/prettier> _{reported by reviewdog 🐶}
Delete ·

pear-desktop/src/plugins/better-fullscreen/index.ts

Line 282 in 0164e40

ui.art.onload = updateColors;

🚫 [eslint] <prettier/prettier> _{reported by reviewdog 🐶}
Delete ·

pear-desktop/src/plugins/better-fullscreen/index.ts

Line 283 in 0164e40

}

🚫 [eslint] <prettier/prettier> _{reported by reviewdog 🐶}
Delete ·

pear-desktop/src/plugins/better-fullscreen/index.ts

Line 288 in 0164e40

lastSrc = currentSrc;

🚫 [eslint] <prettier/prettier> _{reported by reviewdog 🐶}
Delete ·

pear-desktop/src/plugins/better-fullscreen/index.ts

Line 289 in 0164e40

retryCount = 0;

🚫 [eslint] <prettier/prettier> _{reported by reviewdog 🐶}
Delete ·

pear-desktop/src/plugins/better-fullscreen/index.ts

Line 290 in 0164e40

if (title && artist) {

🚫 [eslint] <prettier/prettier> _{reported by reviewdog 🐶}
Replace ···············ui.lines!.innerHTML·= with ············ui.lines!.innerHTML·=⏎·············

pear-desktop/src/plugins/better-fullscreen/index.ts

Line 291 in 0164e40

ui.lines!.innerHTML = '<div class="bfs-empty">Searching lyrics...</div>';

🚫 [eslint] <prettier/prettier> _{reported by reviewdog 🐶}
Delete ···

pear-desktop/src/plugins/better-fullscreen/index.ts

Line 292 in 0164e40

performFetch(title, artist, video.duration);

🚫 [eslint] <prettier/prettier> _{reported by reviewdog 🐶}
Delete ·

pear-desktop/src/plugins/better-fullscreen/index.ts

Line 293 in 0164e40

}

🚫 [eslint] <prettier/prettier> _{reported by reviewdog 🐶}
Replace => with ·=>·

pear-desktop/src/plugins/better-fullscreen/index.ts

Line 317 in 0164e40

document.documentElement.requestFullscreen().catch(()=>{});

🚫 [eslint] <prettier/prettier> _{reported by reviewdog 🐶}
Replace ·document.exitFullscreen().catch(()=> with ⏎············document.exitFullscreen().catch(()·=>·

pear-desktop/src/plugins/better-fullscreen/index.ts

Line 320 in 0164e40

if (document.fullscreenElement) document.exitFullscreen().catch(()=>{});

🚫 [eslint] <prettier/prettier> _{reported by reviewdog 🐶}
Replace .getElementById('bfs-close') with ⏎········.getElementById('bfs-close')⏎········

pear-desktop/src/plugins/better-fullscreen/index.ts

Line 324 in 0164e40

    
           document.getElementById('bfs-close')?.addEventListener('click', () => toggleFS(false));

🚫 [eslint] <prettier/prettier> _{reported by reviewdog 🐶}
Replace e with (e)

pear-desktop/src/plugins/better-fullscreen/index.ts

Line 325 in 0164e40

window.addEventListener('keydown', e => {

🚫 [eslint] <stylistic/arrow-parens> _{reported by reviewdog 🐶}
Expected parentheses around arrow function argument.

pear-desktop/src/plugins/better-fullscreen/index.ts

Line 325 in 0164e40

window.addEventListener('keydown', e => {

🚫 [eslint] <prettier/prettier> _{reported by reviewdog 🐶}
Insert ·

pear-desktop/src/plugins/better-fullscreen/index.ts

Line 326 in 0164e40

if(e.key === 'F12') toggleFS(!isFullscreen);

🚫 [eslint] <prettier/prettier> _{reported by reviewdog 🐶}
Insert ·

pear-desktop/src/plugins/better-fullscreen/index.ts

Line 327 in 0164e40

if(e.key === 'Escape') toggleFS(false);

🚫 [eslint] <prettier/prettier> _{reported by reviewdog 🐶}
Replace (e.target·!==·ui.settingsBtn·&&·!ui.settingsModal?.contains(e.target·as·Node) with ·(⏎··········e.target·!==·ui.settingsBtn·&&⏎··········!ui.settingsModal?.contains(e.target·as·Node)⏎········

pear-desktop/src/plugins/better-fullscreen/index.ts

Line 335 in 0164e40

    
           if(e.target !== ui.settingsBtn && !ui.settingsModal?.contains(e.target as Node)) {

🚫 [eslint] <prettier/prettier> _{reported by reviewdog 🐶}
Delete ·

pear-desktop/src/plugins/better-fullscreen/index.ts

Line 336 in 0164e40

ui.settingsModal?.classList.remove('active');

🚫 [eslint] <@typescript-eslint/no-unsafe-member-access> _{reported by reviewdog 🐶}
Unsafe member access .perfectSync on an any value.

pear-desktop/src/plugins/better-fullscreen/index.ts

Line 341 in 0164e40

config.perfectSync = (e.target as HTMLInputElement).checked;

🚫 [eslint] <@typescript-eslint/no-unsafe-call> _{reported by reviewdog 🐶}
Unsafe call of a(n) any typed value.

pear-desktop/src/plugins/better-fullscreen/index.ts

Line 342 in 0164e40

ctx.setConfig(config);

🚫 [eslint] <@typescript-eslint/no-unsafe-member-access> _{reported by reviewdog 🐶}
Unsafe member access .setConfig on an any value.

pear-desktop/src/plugins/better-fullscreen/index.ts

Line 342 in 0164e40

ctx.setConfig(config);

🚫 [eslint] <@typescript-eslint/require-await> _{reported by reviewdog 🐶}
Async arrow function has no 'await' expression.

pear-desktop/src/plugins/better-fullscreen/index.ts

Line 345 in 0164e40

ui.optRoman?.addEventListener('change', async (e) => {

🚫 [eslint] <@typescript-eslint/no-unsafe-member-access> _{reported by reviewdog 🐶}
Unsafe member access .romanize on an any value.

pear-desktop/src/plugins/better-fullscreen/index.ts

Line 346 in 0164e40

config.romanize = (e.target as HTMLInputElement).checked;

🚫 [eslint] <@typescript-eslint/no-unsafe-call> _{reported by reviewdog 🐶}
Unsafe call of a(n) any typed value.

pear-desktop/src/plugins/better-fullscreen/index.ts

Line 347 in 0164e40

ctx.setConfig(config);

🚫 [eslint] <@typescript-eslint/no-unsafe-member-access> _{reported by reviewdog 🐶}
Unsafe member access .setConfig on an any value.

pear-desktop/src/plugins/better-fullscreen/index.ts

Line 347 in 0164e40

ctx.setConfig(config);

🚫 [eslint] <prettier/prettier> _{reported by reviewdog 🐶}
Insert ·

pear-desktop/src/plugins/better-fullscreen/index.ts

Line 351 in 0164e40

if(title && artist && video) {

🚫 [eslint] <prettier/prettier> _{reported by reviewdog 🐶}
Delete ·

pear-desktop/src/plugins/better-fullscreen/index.ts

Line 352 in 0164e40

ui.lines!.innerHTML = '<div class="bfs-empty">Processing...</div>';

🚫 [eslint] <prettier/prettier> _{reported by reviewdog 🐶}
Delete ·

pear-desktop/src/plugins/better-fullscreen/index.ts

Line 353 in 0164e40

performFetch(title, artist, video.duration);

🚫 [eslint] <prettier/prettier> _{reported by reviewdog 🐶}
Replace ·const·v=document.querySelector('video');·if(v)·v.paused?v.play():v.pause(); with ⏎········const·v·=·document.querySelector('video');⏎········if·(v)·v.paused·?·v.play()·:·v.pause();⏎·····

pear-desktop/src/plugins/better-fullscreen/index.ts

Line 357 in 0164e40

    
           ui.playBtn?.addEventListener('click', () => { const v=document.querySelector('video'); if(v) v.paused?v.play():v.pause(); });

🚫 [eslint] <@typescript-eslint/no-unused-expressions> _{reported by reviewdog 🐶}
Expected an assignment or function call and instead saw an expression.

pear-desktop/src/plugins/better-fullscreen/index.ts

Line 357 in 0164e40

    
           ui.playBtn?.addEventListener('click', () => { const v=document.querySelector('video'); if(v) v.paused?v.play():v.pause(); });

🚫 [eslint] <prettier/prettier> _{reported by reviewdog 🐶}
Replace ·(document.querySelector('.previous-button')·as·HTMLElement)?.click() with ⏎········(document.querySelector('.previous-button')·as·HTMLElement)?.click(),⏎······

pear-desktop/src/plugins/better-fullscreen/index.ts

Line 358 in 0164e40

    
           ui.prevBtn?.addEventListener('click', () => (document.querySelector('.previous-button') as HTMLElement)?.click());

🚫 [eslint] <prettier/prettier> _{reported by reviewdog 🐶}
Replace ·(document.querySelector('.next-button')·as·HTMLElement)?.click() with ⏎········(document.querySelector('.next-button')·as·HTMLElement)?.click(),⏎······

pear-desktop/src/plugins/better-fullscreen/index.ts

Line 359 in 0164e40

    
           ui.nextBtn?.addEventListener('click', () => (document.querySelector('.next-button') as HTMLElement)?.click());

🚫 [eslint] <prettier/prettier> _{reported by reviewdog 🐶}
Replace ··const·v·=·document.querySelector('video');·if(!v) with const·v·=·document.querySelector('video');⏎········if·(!v)·

pear-desktop/src/plugins/better-fullscreen/index.ts

Line 361 in 0164e40

const v = document.querySelector('video'); if(!v)return;

🚫 [eslint] <prettier/prettier> _{reported by reviewdog 🐶}
Delete ··

pear-desktop/src/plugins/better-fullscreen/index.ts

Line 362 in 0164e40

const rect = ui.seek!.getBoundingClientRect();

🚫 [eslint] <prettier/prettier> _{reported by reviewdog 🐶}
Delete ··

pear-desktop/src/plugins/better-fullscreen/index.ts

Line 363 in 0164e40

v.currentTime = ((e.clientX - rect.left) / rect.width) * v.duration;

🚫 [eslint] <prettier/prettier> _{reported by reviewdog 🐶}
Delete ········

pear-desktop/src/plugins/better-fullscreen/index.ts

Line 369 in 0164e40

🚫 [eslint] <stylistic/quotes> _{reported by reviewdog 🐶}
Strings must use singlequote.

pear-desktop/src/plugins/better-fullscreen/index.ts

Line 374 in 0164e40

    
           btn.innerHTML = `<svg width="24" height="24" viewBox="0 0 24 24" fill="none" stroke="currentColor" stroke-width="2"><path d="M15 3h6v6M9 21H3v-6M21 3l-7 7M3 21l7-7"/></svg>`;

🚫 [eslint] <prettier/prettier> _{reported by reviewdog 🐶}
Delete ··········

pear-desktop/src/plugins/better-fullscreen/index.ts

Line 375 in 0164e40

🚫 [eslint] <prettier/prettier> _{reported by reviewdog 🐶}
Delete ·

pear-desktop/src/plugins/better-fullscreen/index.ts

Line 376 in 0164e40

btn.onclick = (e) => {

🚫 [eslint] <prettier/prettier> _{reported by reviewdog 🐶}
Delete ·

pear-desktop/src/plugins/better-fullscreen/index.ts

Line 377 in 0164e40

e.stopPropagation();

🚫 [eslint] <prettier/prettier> _{reported by reviewdog 🐶}
Delete ·

pear-desktop/src/plugins/better-fullscreen/index.ts

Line 378 in 0164e40

toggleFS(true);

🚫 [eslint] <prettier/prettier> _{reported by reviewdog 🐶}
Delete ··········

pear-desktop/src/plugins/better-fullscreen/index.ts

Line 380 in 0164e40

🚫 [eslint] <prettier/prettier> _{reported by reviewdog 🐶}
Insert ·

pear-desktop/src/plugins/better-fullscreen/index.ts

Line 381 in 0164e40

if(getComputedStyle(artContainer).position === 'static') {

🚫 [eslint] <prettier/prettier> _{reported by reviewdog 🐶}
Delete ·

pear-desktop/src/plugins/better-fullscreen/index.ts

Line 382 in 0164e40

(artContainer as HTMLElement).style.position = 'relative';

🚫 [eslint] <prettier/prettier> _{reported by reviewdog 🐶}
Delete ··········

pear-desktop/src/plugins/better-fullscreen/index.ts

Line 384 in 0164e40

🚫 [eslint] <prettier/prettier> _{reported by reviewdog 🐶}
Insert ,

pear-desktop/src/plugins/better-fullscreen/index.ts

Line 388 in 0164e40

}

🚫 [eslint] <prettier/prettier> _{reported by reviewdog 🐶}
Insert ,

pear-desktop/src/plugins/better-fullscreen/index.ts

Line 389 in 0164e40

}

🚫 [eslint] <prettier/prettier> _{reported by reviewdog 🐶}
Insert ⏎

pear-desktop/src/plugins/better-fullscreen/index.ts

Line 390 in 0164e40

});

🚫 [eslint] <prettier/prettier> _{reported by reviewdog 🐶}
Replace ·text:·string;·timeMs:·number;·romaji?:·string;· with ⏎··text:·string;⏎··timeMs:·number;⏎··romaji?:·string;⏎

pear-desktop/src/plugins/better-fullscreen/lyrics.ts

Line 1 in 0164e40

export interface LyricLine { text: string; timeMs: number; romaji?: string; }

🚫 [eslint] <prettier/prettier> _{reported by reviewdog 🐶}
Replace ·lines?:·LyricLine[];·plain?:·string;·synced:·boolean;· with ⏎··lines?:·LyricLine[];⏎··plain?:·string;⏎··synced:·boolean;⏎

pear-desktop/src/plugins/better-fullscreen/lyrics.ts

Line 2 in 0164e40

    
           export interface LyricResult { lines?: LyricLine[]; plain?: string; synced: boolean; }

🚫 [eslint] <no-control-regex> _{reported by reviewdog 🐶}
Unexpected control character(s) in regular expression: \x00.

pear-desktop/src/plugins/better-fullscreen/lyrics.ts

Line 7 in 0164e40

if (!text || /^[\x00-\x7F]*$/.test(text)) return text;

🚫 [eslint] <prettier/prettier> _{reported by reviewdog 🐶}
Delete ·

pear-desktop/src/plugins/better-fullscreen/lyrics.ts

Line 7 in 0164e40

if (!text || /^[\x00-\x7F]*$/.test(text)) return text;

🚫 [eslint] <prettier/prettier> _{reported by reviewdog 🐶}
Delete ····

pear-desktop/src/plugins/better-fullscreen/lyrics.ts

Line 14 in 0164e40

🚫 [eslint] <prettier/prettier> _{reported by reviewdog 🐶}
Delete ······

pear-desktop/src/plugins/better-fullscreen/lyrics.ts

Line 17 in 0164e40

🚫 [eslint] <@typescript-eslint/no-explicit-any> _{reported by reviewdog 🐶}
Unexpected any. Specify a different type.

pear-desktop/src/plugins/better-fullscreen/lyrics.ts

Line 18 in 0164e40

data[0].forEach((chunk: any) => {

🚫 [eslint] <prettier/prettier> _{reported by reviewdog 🐶}
Replace ··········if with ········if·

pear-desktop/src/plugins/better-fullscreen/lyrics.ts

Line 19 in 0164e40

if(Array.isArray(chunk)) {

🚫 [eslint] <prettier/prettier> _{reported by reviewdog 🐶}
Delete ····

pear-desktop/src/plugins/better-fullscreen/lyrics.ts

Line 20 in 0164e40

const possibleRomaji = chunk[chunk.length - 1];

🚫 [eslint] <prettier/prettier> _{reported by reviewdog 🐶}
Replace ·······if·(typeof·possibleRomaji·===·'string'·&&·possibleRomaji·!==·text·&&·!possibleRomaji.includes(text))·{ with ···if·(⏎············typeof·possibleRomaji·===·'string'·&&⏎············possibleRomaji·!==·text·&&⏎············!possibleRomaji.includes(text)

pear-desktop/src/plugins/better-fullscreen/lyrics.ts

Line 21 in 0164e40

    
           if (typeof possibleRomaji === 'string' && possibleRomaji !== text && !possibleRomaji.includes(text)) {

🚫 [eslint] <prettier/prettier> _{reported by reviewdog 🐶}
Replace ·········· with ··)·{⏎············

pear-desktop/src/plugins/better-fullscreen/lyrics.ts

Line 22 in 0164e40

romajiFull += possibleRomaji + ' ';

🚫 [eslint] <prettier/prettier> _{reported by reviewdog 🐶}
Delete ····

pear-desktop/src/plugins/better-fullscreen/lyrics.ts

Line 23 in 0164e40

}

🚫 [eslint] <prettier/prettier> _{reported by reviewdog 🐶}
Replace ·········· with ········

pear-desktop/src/plugins/better-fullscreen/lyrics.ts

Line 24 in 0164e40

}

🚫 [eslint] <prettier/prettier> _{reported by reviewdog 🐶}
Delete ··

pear-desktop/src/plugins/better-fullscreen/lyrics.ts

Line 28 in 0164e40

return romajiFull.trim();

⚠️ [eslint] <@typescript-eslint/no-unused-vars> _{reported by reviewdog 🐶}
'e' is defined but never used.

pear-desktop/src/plugins/better-fullscreen/lyrics.ts

Line 31 in 0164e40

} catch (e) {}

🚫 [eslint] <prettier/prettier> _{reported by reviewdog 🐶}
Delete ·

pear-desktop/src/plugins/better-fullscreen/lyrics.ts

Line 43 in 0164e40

.replace(/ - .*?$/, '')

🚫 [eslint] <prettier/prettier> _{reported by reviewdog 🐶}
Replace line with (line)

pear-desktop/src/plugins/better-fullscreen/lyrics.ts

Line 50 in 0164e40

lrc.split('\n').forEach(line => {

🚫 [eslint] <stylistic/arrow-parens> _{reported by reviewdog 🐶}
Expected parentheses around arrow function argument.

pear-desktop/src/plugins/better-fullscreen/lyrics.ts

Line 50 in 0164e40

lrc.split('\n').forEach(line => {

🚫 [eslint] <prettier/prettier> _{reported by reviewdog 🐶}
Replace (min·*·60·*·1000)·+·(sec·*·1000) with min·*·60·*·1000·+·sec·*·1000

pear-desktop/src/plugins/better-fullscreen/lyrics.ts

Line 57 in 0164e40

if (text) lines.push({ timeMs: (min * 60 * 1000) + (sec * 1000) + ms, text });

🚫 [eslint] <prettier/prettier> _{reported by reviewdog 🐶}
Replace title:·string,·artist:·string,·duration:·number,·romanize:·boolean·=·false with ⏎··title:·string,⏎··artist:·string,⏎··duration:·number,⏎··romanize:·boolean·=·false,⏎

pear-desktop/src/plugins/better-fullscreen/lyrics.ts

Line 64 in 0164e40

    
           export const getLyrics = async (title: string, artist: string, duration: number, romanize: boolean = false): Promise<LyricResult | null> => {

🚫 [eslint] <prettier/prettier> _{reported by reviewdog 🐶}
Delete ····

pear-desktop/src/plugins/better-fullscreen/lyrics.ts

Line 68 in 0164e40

🚫 [eslint] <prettier/prettier> _{reported by reviewdog 🐶}
Delete ····

pear-desktop/src/plugins/better-fullscreen/lyrics.ts

Line 71 in 0164e40

🚫 [eslint] <prettier/prettier> _{reported by reviewdog 🐶}
Insert ·

pear-desktop/src/plugins/better-fullscreen/lyrics.ts

Line 73 in 0164e40

if(!res.ok) return null;

🚫 [eslint] <prettier/prettier> _{reported by reviewdog 🐶}
Delete ····

pear-desktop/src/plugins/better-fullscreen/lyrics.ts

Line 74 in 0164e40

🚫 [eslint] <prettier/prettier> _{reported by reviewdog 🐶}
Insert ·

pear-desktop/src/plugins/better-fullscreen/lyrics.ts

Line 76 in 0164e40

if(!Array.isArray(list) || list.length === 0) return null;

🚫 [eslint] <prettier/prettier> _{reported by reviewdog 🐶}
Delete ·

pear-desktop/src/plugins/better-fullscreen/lyrics.ts

Line 79 in 0164e40

const aHasSync = !!a.syncedLyrics;

🚫 [eslint] <prettier/prettier> _{reported by reviewdog 🐶}
Delete ·

pear-desktop/src/plugins/better-fullscreen/lyrics.ts

Line 80 in 0164e40

const bHasSync = !!b.syncedLyrics;

🚫 [eslint] <prettier/prettier> _{reported by reviewdog 🐶}
Replace ·······if with ······if·

pear-desktop/src/plugins/better-fullscreen/lyrics.ts

Line 81 in 0164e40

if(aHasSync !== bHasSync) return bHasSync ? 1 : -1;

🚫 [eslint] <prettier/prettier> _{reported by reviewdog 🐶}
Replace ·return·Math.abs(a.duration·-·targetDur)·-·Math.abs(b.duration·-·targetDur) with return·(⏎········Math.abs(a.duration·-·targetDur)·-·Math.abs(b.duration·-·targetDur)⏎······)

pear-desktop/src/plugins/better-fullscreen/lyrics.ts

Line 82 in 0164e40

return Math.abs(a.duration - targetDur) - Math.abs(b.duration - targetDur);

🚫 [eslint] <prettier/prettier> _{reported by reviewdog 🐶}
Replace (best.syncedLyrics) with ·(best.syncedLyrics)⏎·····

pear-desktop/src/plugins/better-fullscreen/lyrics.ts

Line 88 in 0164e40

    
           if(best.syncedLyrics) result = { lines: parseLRC(best.syncedLyrics), synced: true };

🚫 [eslint] <@typescript-eslint/no-unsafe-argument> _{reported by reviewdog 🐶}
Unsafe argument of type error typed assigned to a parameter of type string.

pear-desktop/src/plugins/better-fullscreen/lyrics.ts

Line 88 in 0164e40

    
           if(best.syncedLyrics) result = { lines: parseLRC(best.syncedLyrics), synced: true };

🚫 [eslint] <prettier/prettier> _{reported by reviewdog 🐶}
Replace (best.plainLyrics) with ·(best.plainLyrics)⏎·····

pear-desktop/src/plugins/better-fullscreen/lyrics.ts

Line 89 in 0164e40

else if(best.plainLyrics) result = { plain: best.plainLyrics, synced: false };

🚫 [eslint] <@typescript-eslint/no-unsafe-assignment> _{reported by reviewdog 🐶}
Unsafe assignment of an error typed value.

pear-desktop/src/plugins/better-fullscreen/lyrics.ts

Line 89 in 0164e40

else if(best.plainLyrics) result = { plain: best.plainLyrics, synced: false };

🚫 [eslint] <prettier/prettier> _{reported by reviewdog 🐶}
Delete ··

pear-desktop/src/plugins/better-fullscreen/lyrics.ts

Line 93 in 0164e40

if (result.lines) {

🚫 [eslint] <prettier/prettier> _{reported by reviewdog 🐶}
Delete ····

pear-desktop/src/plugins/better-fullscreen/lyrics.ts

Line 94 in 0164e40

const promises = result.lines.map(async (line) => {

🚫 [eslint] <prettier/prettier> _{reported by reviewdog 🐶}
Delete ······

pear-desktop/src/plugins/better-fullscreen/lyrics.ts

Line 95 in 0164e40

const romaji = await googleRomanize(line.text);

🚫 [eslint] <prettier/prettier> _{reported by reviewdog 🐶}
Replace ················ with ··········

pear-desktop/src/plugins/better-fullscreen/lyrics.ts

Line 96 in 0164e40

if (romaji && romaji.toLowerCase() !== line.text.toLowerCase()) {

🚫 [eslint] <prettier/prettier> _{reported by reviewdog 🐶}
Delete ········

pear-desktop/src/plugins/better-fullscreen/lyrics.ts

Line 97 in 0164e40

return { ...line, romaji };

🚫 [eslint] <prettier/prettier> _{reported by reviewdog 🐶}
Replace ················ with ··········

pear-desktop/src/plugins/better-fullscreen/lyrics.ts

Line 98 in 0164e40

}

🚫 [eslint] <prettier/prettier> _{reported by reviewdog 🐶}
Delete ······

pear-desktop/src/plugins/better-fullscreen/lyrics.ts

Line 99 in 0164e40

return line;

🚫 [eslint] <prettier/prettier> _{reported by reviewdog 🐶}
Delete ····

pear-desktop/src/plugins/better-fullscreen/lyrics.ts

Line 100 in 0164e40

});

🚫 [eslint] <prettier/prettier> _{reported by reviewdog 🐶}
Replace ············ with ········

pear-desktop/src/plugins/better-fullscreen/lyrics.ts

Line 101 in 0164e40

result.lines = await Promise.all(promises);

🚫 [eslint] <prettier/prettier> _{reported by reviewdog 🐶}
Delete ··

pear-desktop/src/plugins/better-fullscreen/lyrics.ts

Line 102 in 0164e40

}

🚫 [eslint] <prettier/prettier> _{reported by reviewdog 🐶}
Replace ⏎··}·catch·(e)·{·console.warn('Lyrics·Error:',·e); with ··}·catch·(e)·{⏎····console.warn('Lyrics·Error:',·e);⏎·

pear-desktop/src/plugins/better-fullscreen/lyrics.ts

Lines 106 to 107 in 0164e40


	} catch (e) { console.warn('Lyrics Error:', e); }

🚫 [eslint] <prettier/prettier> _{reported by reviewdog 🐶}
Insert ⏎

pear-desktop/src/plugins/better-fullscreen/lyrics.ts

Line 109 in 0164e40

};

src/plugins/better-fullscreen/index.ts

feat: add Better Fullscreen plugin

0164e40

github-actions bot reviewed Dec 9, 2025

View reviewed changes

noobpro45 marked this pull request as draft December 9, 2025 21:48

feat: add Better Fullscreen plugin

04473ad

noobpro45 marked this pull request as ready for review December 10, 2025 10:40

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat: Add Better Fullscreen plugin #4138

feat: Add Better Fullscreen plugin #4138

Uh oh!

noobpro45 commented Dec 9, 2025

Uh oh!

github-actions bot left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

feat: Add Better Fullscreen plugin #4138

Are you sure you want to change the base?

feat: Add Better Fullscreen plugin #4138

Uh oh!

Conversation

noobpro45 commented Dec 9, 2025

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant