Skip to content

Initial Snowy, Tintin, and Chalk(?) support for About window #82

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jwise merged 10 commits into from
Sep 15, 2019
Merged

Initial Snowy, Tintin, and Chalk(?) support for About window #82

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
6054e14
Updated about screen to match current project.
tertty Sep 8, 2019
298b239
Update resource pack with about screen icons.
jwise Sep 11, 2019
98f369c
Updated Discord link
tertty Sep 12, 2019
2dc6324
res: add Renaissance fonts
jwise Sep 14, 2019
6767af4
Stop update layer from redrawing bitmaps each time
tertty Sep 14, 2019
5115aae
Updated about screen to match current project.
tertty Sep 8, 2019
ad22f7b
Updated Discord link
tertty Sep 12, 2019
3261de7
Stop update layer from redrawing bitmaps each time
tertty Sep 14, 2019
ece5963
Merge branch 'about_screen' of https://github.com/tertty/RebbleOS int…
tertty Sep 15, 2019
0669fec
Taking out the garbage and leaking aplite_love
tertty Sep 15, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 18 additions & 3 deletions Apps/System/systemapp.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,10 @@ static Window *s_about_window;
static Layer *s_aboutCanvas_layer;
static ScrollLayer *s_about_scroll;
static void about_update_proc(Layer *layer, GContext *nGContext);
static GBitmap *logo_color;
static GBitmap *rocket_color;
static GBitmap *logo_bw;
static GBitmap *rocket_color;

StatusBarLayer *status_bar;

Expand Down Expand Up @@ -184,6 +188,15 @@ static void about_window_load(Window *window)

layer_add_child(window_layer, scroll_layer_get_layer(s_about_scroll));
layer_add_child(window_layer, status_bar_layer_get_layer(status_bar));

#ifdef PBL_BW
logo_bw = gbitmap_create_with_resource(RESOURCE_ID_REBBLE_LOGO_BW);
//TODO: rocket_bw =
#else
logo_color = gbitmap_create_with_resource(RESOURCE_ID_REBBLE_LOGO_DARK);
rocket_color = gbitmap_create_with_resource(RESOURCE_ID_TO_MOON);
#endif

}

static void about_update_proc(Layer *layer, GContext *nGContext)
Expand All @@ -207,18 +220,20 @@ static void about_update_proc(Layer *layer, GContext *nGContext)
GTextOverflowModeTrailingEllipsis, GTextAlignmentCenter, 0);

#ifdef PBL_BW
graphics_draw_bitmap_in_rect(nGContext, gbitmap_create_with_resource(RESOURCE_ID_REBBLE_LOGO_BW), GRect((bounds.size.w/2)-17, (bounds.size.h/2)-63, 34, 53));
graphics_draw_bitmap_in_rect(nGContext, logo_bw, GRect((bounds.size.w/2)-17, (bounds.size.h/2)-63, 34, 53));
//TODO: Get black and white rocket bitmap for Classic
//graphics_draw_bitmap_in_rect(nGContext, gbitmap_create_with_resource(RESOURCE_ID_TO_MOON_BW), GRect((bounds.size.w/2)-8, (bounds.size.h/2)+60, 19, 19));
#else
graphics_draw_bitmap_in_rect(nGContext, gbitmap_create_with_resource(RESOURCE_ID_REBBLE_LOGO_DARK), GRect((bounds.size.w/2)-17, (bounds.size.h/2)-63, 34, 53));
graphics_draw_bitmap_in_rect(nGContext, gbitmap_create_with_resource(RESOURCE_ID_TO_MOON), GRect((bounds.size.w/2)-8, (bounds.size.h/2)+60, 19, 19));
graphics_draw_bitmap_in_rect(nGContext, logo_color, GRect((bounds.size.w/2)-17, (bounds.size.h/2)-63, 34, 53));
graphics_draw_bitmap_in_rect(nGContext, rocket_color, GRect((bounds.size.w/2)-8, (bounds.size.h/2)+60, 19, 19));
#endif
}

static void about_window_unload(Window *window)
{
scroll_layer_destroy(s_about_scroll);
gbitmap_destroy(logo_color);
Copy link
Contributor

@jwise jwise Sep 14, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that this only works on color, and breaks on B&W. Recommend just having 'logo' and 'rocket', and conditionally initializing them on B&W and color (and assigning them to NULL); then checking for NULL when you destroy. i.e.,

static GBitmap *logo;
...
logo = create(...);
...
if (logo)
   graphics_draw_bitmap_in_rect...
...
if (logo)
  gbitmap_destroy(logo);

Copy link
Member Author

@tertty tertty Sep 15, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great idea, not sure why I didn't think of it. Implemented something similar I think will work, let me know if I need to revise.

gbitmap_destroy(rocket_color);
}

void systemapp_init(void)
Expand Down