fix: parse Yarn JSON on any OS #80
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Thanks for the PR 👍 Can you tell me the OS and terminal where Updtr is not working as expected? AppVeyor runs our tests on Windows machines. |
Author
|
i think windows powershell, been a little while |
Member
|
Can you post a link to the yarn source code? Could you also change all occurrences of Could you also undo all format changes not related to this change? I'd be happy to merge this PR asap 😁 🎉 |
|
Is there any update on this PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
yarn will always output a
\nin json output between lines so we should use that instead ofos.EOL