chore(ci): every toolchain step installs the components the toolchain file demands - #1016
Merged
FeathBow merged 1 commit intoAug 31, 2026
Conversation
… file demands Signed-off-by: Feathbow <feathbow@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
rust-toolchain.tomlpinsnightly-2026-07-10withcomponents = ["rustfmt", "clippy"], but most CI jobs install the toolchain with onlyclippy, or with no components at all. The firstcargoinvocation then makes the rustup shim sync the toolchain file and add rustfmt incrementally, and on this nightly that add fails deterministically:The cargo component of this nightly already ships
bin/cargo-fmt, so a single-transaction toolchain install tolerates the overlap while an incrementalcomponent addrefuses it. That is why the fmt job, which installs rustfmt at setup, passes, while the Qwen3.5 CUDA clippy job and every other clippy-only or component-less job dies at its first cargo command.Every
dtolnay/rust-toolchainstep now installsrustfmt, clippyup front, so the shim never has to add a component after the fact.Test Env
GitHub-hosted
ubuntu-latest; the failure happens in rustup before any build, so no GPU is involved.Verification
components:lines in.github/workflows/ci.yml(8 insertions, 4 deletions); no job commands change.