permit SPIFFS_write() on NULL buffer #111
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SPIFFS_write(&spi_fs, fd, buf, count)
withbuf = NULL
can be valid when dumping the firmware of a microcontroller with internal flash mapped to address0x0
.SPIFFS_write(&spi_fs, fd, 0x0, firmware_size)
would previously omit the first page when dumping the firmware to flash (all 0xFF).Visualization of the problem:
Use
len
instead to signal where only page header is stored inspiffs_page_allocate_data
.