Add SPIFFS_ftruncate function #278
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@pellepl sorry for poking you directly. If we added unit tests to cover this new feature, would you consider merging this PR? There is some interest in implementing We would like to avoid forking SPIFFS to add this one function. |
|
Hi @igrr,
Absolutely! Ping me when the tests are added and I'll push it.
Cheers / P
Den ons 16 mars 2022 10:45Ivan Grokhotkov ***@***.***> skrev:
… @pellepl <https://github.com/pellepl> sorry for poking you directly. If
we added unit tests to cover this new feature, would you consider merging
this PR?
There is some interest in implementing truncate and ftruncate support, as
evidenced by #218 <#218>,
espressif/esp-idf#2234 <espressif/esp-idf#2234>,
espressif/esp-idf#2241 <espressif/esp-idf#2241>.
We would like to avoid forking SPIFFS to add this one function.
—
Reply to this email directly, view it on GitHub
<#278 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABG42VYY5HR335C34HQEE7TVAGUVHANCNFSM42LE2QBQ>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
@igrr Great, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a
SPIFFS_ftruncatefunction to hydrogen. It allows behaviour similar to POSIX ftruncate() call except it cannot be used to increase file size. It uses existing nucleus calls with additional checks.