RFC: Simplify API w.r.t. string types and parallelism #455
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This drops the parallel Rust entry points as they offer little over direct usage of Rayon while forcing a copy and requiring the corpus to be available as a slice. The corresponding Python entry points are kept for convenience, but are implemented directly using Rayon instead. Further, all string types are standardized on `&str` thereby avoiding unnecessary allocations when the data is already available in string form. Furthermore, the Python entry points can directly borrow from Python-managed string data via PyO3's `PyBackedStr`. This is obviously not backwards-compatible on the Rust side but I think it is a simpler yet more efficient API to present there and hence wanted to at least propose this even though the difference is probably not worth a major version bump.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This drops the parallel Rust entry points as they offer little over direct usage of Rayon while forcing a copy and requiring the corpus to be available as a slice. The corresponding Python entry points are kept for convenience, but are implemented directly using Rayon instead.
Further, all string types are standardized on
&strthereby avoiding unnecessary allocations when the data is already available in string form. Furthermore, the Python entry points can directly borrow from Python-managed string data via PyO3'sPyBackedStr.This is obviously not backwards-compatible on the Rust side but I think it is a simpler yet more efficient API to present there and hence wanted to at least propose this even though the difference is probably not worth a major version bump.