-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
addition of spacewalk pallets to pendulum #401
Conversation
@ebma should we test the functionality of the newly added pallets in something like zombienet/chopsticks? Or is it okay since we already know they work in Amplitude? WDYT |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me overall. CI failed though. Maybe it's fixed by my suggested code changes, not sure.
I think we should test it but let's rather test the whole runtime when we are about to release. Meaning, I would rather test the runtime once we have the PR to bump spec and transaction versions. |
Co-authored-by: Marcel Ebert <[email protected]>
Makes sense! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like formatting .toml files with rustfmt is an open issue that still has some developments going on. Not sure if it's worth to look for other tooling here in the meantime or to deal with it manually for the time being.
The changes look good to me overall and the CI passed so I think this is ready to merge. (Ideally after the indentation is streamlined but that's just nitpicking.)
Sorry @ebma, I think you need to approve again. I fixed indentations as much as I could and was waiting for the CI. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing it 🙏
@pendulum-chain/product: This PR adds changes to the node client code that require a redeployment of the collator nodes to take effect.
Please ensure that the collator nodes are redeployed after this PR is merged. This is because of the new RPC methods that Spacewalk brings (and genesis config).
Closes #400 .
Changes
This PR is for the addition of all the relevant Spacewalk pallets into the Pendulum runtime. It mostly adopt the same configuration used in Amplitude, except for:
Extra notes