plugins/redirects: Fix tabs are parsed as part of the source #53
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Until now the columns of a `.rr`-files could only be separated by spaces. This regularly leads to not working redirects, where the generated source-file would contain tabs as part of the file name. This comes down to how the regex parses the file: Before this change only spaces were not part of source and destination - but other whitespace was ok. With this change source and destination can not contain any whitespace. Thus tabs are parsed as separators - as one would expect. Signed-off-by: Chris Fiege <[email protected]>
Bastian-Krause
approved these changes
Oct 16, 2025
|
Will merge this for now and fix the failing CI afterwards. We should be fine if we only support python stating at 3.9 or something. It should be safe to drop 3.7... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Until now the columns of a
.rr-files could only be separated by spaces.This regularly leads to not working redirects, where the generated source-file would contain tabs as part of the file name.
This comes down to how the regex parses the file: Before this change only spaces were not part of source and destination - but other whitespace was ok.
With this change source and destination can not contain any whitespace. Thus tabs are parsed as separators - as one would expect.