Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wip: move rand_core requirement under std feature flag #100

Closed
wants to merge 1 commit into from

Conversation

redshiftzero
Copy link
Member

I discovered when compiling poseidon377 using decaf377 0.9.0 on thumbv8m.main-none-eabi that the addition of rand_core in #91 caused a build failure. This is because rand_core requires getrandom, which in turn does not support the target thumbv8m.main-none-eabi (more deets here: https://docs.rs/getrandom/latest/getrandom/#unsupported-targets). This PR sidesteps that issue by moving the new methods requiring rand_core under the std feature flag.

@redshiftzero redshiftzero changed the title move rand_core requirement under std feature flag wip: move rand_core requirement under std feature flag Apr 3, 2024
@redshiftzero
Copy link
Member Author

Closing this as not needed, the build failure I was hitting was due to feature unification causing rand_core to pull in the default getrandom feature, that build is now succeeding: penumbra-zone/poseidon377#53

@redshiftzero redshiftzero deleted the rand_core_under_flag branch April 4, 2024 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant