Governance support for pindexer

[plaidfinch]

Describe your changes

This adds a governance module to pindexer, along with tiny changes to pd's governance events to fully support it.

Checklist before requesting a review

• If this code contains consensus-breaking changes, I have added the "consensus-breaking" label. Otherwise, I declare my belief that there are not consensus-breaking changes, for the following reason:

  The only changes to pd are changes to events emitted, which do not break consensus.

[plaidfinch]

This self-review attempts to explain the changes made, largely focusing on the changes made to pd, as changes to pindexer are self-contained and still in testing/development.

[hdevalence]

There are two high-level changes that need to be made before this can be merged:

• There should be no changes, even refactorings, to consensus-critical code along the way to adding indexer support. At most, new data can be emitted in events. We don't have bandwidth to carefully review changes to consensus-critical logic along the way to adding this logic.

• The data produced by the AppView implementation is expected to be consumed by third-party clients. Thus, the AppView impl should not be defining its own data formats ad-hoc. It should be using the canonical data formats we already have, which can be processed using standardized tooling from the Buf registry.

[plaidfinch]

All changes, even refactors, to consensus-critical code have been backed out, excepting alterations to emitted events.

[plaidfinch]

More self-review on the latest iteration, which I believe resolves the outstanding concerns above.

[hdevalence]

Running this, I get

Error: error returned from database: bind message supplies 0 parameters, but prepared statement "sqlx_s_2" requires 1

Caused by:
    bind message supplies 0 parameters, but prepared statement "sqlx_s_2" requires 1

[plaidfinch]

This has been fixed after I ran into it myself.

…

On Wed, Jul 17, 2024 at 10:20 AM, Henry de Valence ***@***.***(mailto:On Wed, Jul 17, 2024 at 10:20 AM, Henry de Valence <<a href=)> wrote: Running this, I get Error: error returned from database: bind message supplies 0 parameters, but prepared statement "sqlx_s_2" requires 1 Caused by: bind message supplies 0 parameters, but prepared statement "sqlx_s_2" requires 1 — Reply to this email directly, [view it on GitHub](#4708 (comment)), or [unsubscribe](https://github.com/notifications/unsubscribe-auth/AAERYYMKPAENMNT4O27A3BTZMZ4RRAVCNFSM6AAAAABK3OT7O6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMZTGQ2DMOBYGA). You are receiving this because you authored the thread.Message ID: ***@***.***>

[zbuc]

LGTM. @plaidfinch is this ready to merge?

[hdevalence]

This code should have been merged several days ago when @plaidfinch and I pushed it up to the finish line and it was reviewed and approved. It needs to go in as-is, not be rewritten again.

[conorsch]

Tested locally in dev env, works well. My earlier comments about the proto namespaces have been addressed. I see no reason not to ship this. Separately let's follow up with pindexer-focused docs that stipulate the version-matching and genesis-preservation reqs.