build: fix nix-build via allowing asset files #4796
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can confirm Tested with |
Adds a comprehensive allow-list of file extensions to the nix build context. Includes zip files, which will fail a build as of #4782, and other flat file inputs like CSV and JSON for testnet generation. Also adds the `pindexer` binary to the nix-build outputs.
conorsch
force-pushed
the
4790-fix-nix-build
branch
from
190e867
to
2f9c1d8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Adds a comprehensive allow-list of file extensions to the nix build context. Includes zip files, which will fail a build as of #4782, and other flat file inputs like CSV and JSON for testnet generation. Also adds the
pindexerbinary to the nix-build outputs.Issue ticket number and link
Refs #4782. Doesn't close it, because it'd be nice to tack on a CI job that guards against breakage. Will follow up with that separately.
Checklist before requesting a review
If this code contains consensus-breaking changes, I have added the "consensus-breaking" label. Otherwise, I declare my belief that there are not consensus-breaking changes, for the following reason:
Testing and review
nix buildin the repo root