vendor R1CS sponge code #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is the `r1cs` branch from our git fork of `ark-sponge`: https://github.com/penumbra-zone/sponge It is unmodified in this commit, changes will be made in the subsequent commits for clarity of the git history. The upstream `ark-sponge` repository is archived because they moved the poseidon implementation to a different repository. In addition, we need to make a lot of changes to get on the upstream impl. This was attempted back in November and at that time we decided to continue using our fork only for the R1CS feature. However, in light of the upcoming migration to Poseidon2, any work resolving the divergence between our fork and the upstream repo would be wasted, as we'll be soon removing Poseidon 1 from `poseidon377`. As such, for stability, we are vendoring our fork of `ark-sponge` on a temporary basis such that we can release `poseidon377` unchanged to crates, then pin all penumbra repositories to that release. Afterwards, we will proceed with migrating to Arkworks 0.4.x release series [0] and migrating to Poseidon2 [1]. [0] penumbra-zone/penumbra#2004 [1] #40
paths to the crate root `crate` in vendored `ark-sponge` need to be `crate::r1cs::vendor::sponge`
This test is failing in the forked repo, after the change in: penumbra-zone/sponge@113469a That change was previously made for consistency with our `poseidon377` test vectors (after ark-sponge changed how they invoke the permutation in the sponge). Our poseidon377 vectors are `crate::hash` in the tests as well as in the protocol spec - those tests pass so there should be no issues with consistency across implementations.
18 tasks
(needed for publishing to crates)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards penumbra-zone/penumbra#2004:
poseidon377crate, and will be deleted after Support Poseidon2 #40.poseidon377to crates.io, and pin all Penumbra crates to thatposeidon377release.