Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add feature guard to unix-only listener in v038 #47

Merged
merged 1 commit into from
May 10, 2024

Conversation

tzemanovic
Copy link
Contributor

fixes non-unix build

@cratelyn cratelyn self-requested a review May 10, 2024 14:44
@cratelyn
Copy link

cratelyn commented May 10, 2024

; git show --oneline --quiet HEAD
4b73065 (HEAD -> main, origin/main, origin/HEAD) tower-abci: use `[email protected]` (#46)
; cargo build --quiet --target x86_64-pc-windows-msvc && echo "build passed"
error[E0432]: unresolved import `tokio::net::UnixListener`
  --> src/v038/server.rs:9:39
   |
9  |     net::{TcpListener, ToSocketAddrs, UnixListener},
   |                                       ^^^^^^^^^^^^
   |                                       |
   |                                       no `UnixListener` in `net`
   |                                       help: a similar name exists in the module: `TcpListener`
   |
note: found an item that was configured out
  --> .cargo/registry/src/index.crates.io-6f17d22bba15001f/tokio-1.35.1/src/net/mod.rs:50:29
   |
50 |     pub use unix::listener::UnixListener;
   |                             ^^^^^^^^^^^^

For more information about this error, try `rustc --explain E0432`.
error: could not compile `tower-abci` (lib) due to 1 previous error
; git switch unix-guard-v038
branch 'unix-guard-v038' set up to track 'heliaxdev/unix-guard-v038'.
Switched to a new branch 'unix-guard-v038'
; git show --oneline --quiet HEAD
52382f4 (HEAD -> unix-guard-v038, heliaxdev/unix-guard-v038) add feature guard to unix-only listener in v038
; cargo build --quiet --target x86_64-pc-windows-msvc && echo "build passed"
build passed

i've confirmed that this fixes a non-unix build by cross-compiling for a windows target.

Copy link

@cratelyn cratelyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks! this looks good to me.

@cratelyn cratelyn merged commit e39c13b into penumbra-zone:main May 10, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants