Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

react provider 5 #1467

Closed
wants to merge 1 commit into from
Closed

react provider 5 #1467

wants to merge 1 commit into from

Conversation

turbocrime
Copy link
Contributor

@turbocrime turbocrime commented Jul 11, 2024

example query hooks pending other react PRs

things like this could be exported from the react package as hooks for consumers

we should

  1. decide if that's a good idea
  2. identify appropriate data for which to provide prewritten queriers
  3. don't make queriers that are very thin (exported queriers should provide actual benefit. use-assets and use-assets-metadata are probably not appropriate)
  4. (2) and (3) probably mean, queriers should be multi-endpoint requests that manipulate data. but then we need to worry about defining good interfaces/types for returned data.
  5. examine the possibility of using or encouraging consumers to use connect-query instead
  6. examine the possibility of doing upstream work on connect-query to add stream support, obviating this entire class of work

Copy link

changeset-bot bot commented Jul 11, 2024

⚠️ No Changeset found

Latest commit: 5f6a960

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@turbocrime turbocrime changed the base branch from main to turbocrime/react-wallet-4 July 11, 2024 01:58
@turbocrime turbocrime force-pushed the turbocrime/react-provider-5 branch 2 times, most recently from 848cc1e to 67d1df7 Compare July 11, 2024 02:25
@turbocrime turbocrime requested a review from a team July 11, 2024 02:25
@turbocrime turbocrime changed the base branch from turbocrime/react-wallet-4 to turbocrime/react-wallet-3 July 12, 2024 06:03
Base automatically changed from turbocrime/react-wallet-3 to main July 15, 2024 08:55
@VanishMax
Copy link
Contributor

@turbocrime could you rebase this?

@turbocrime
Copy link
Contributor Author

rebased. keep in mind these are example queriers, not intended to merge yet

@turbocrime turbocrime closed this Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants