Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

re-enable react refresh lint #1512

Closed
wants to merge 1 commit into from
Closed

Conversation

turbocrime
Copy link
Contributor

and fix

Copy link

changeset-bot bot commented Jul 18, 2024

⚠️ No Changeset found

Latest commit: 81d3418

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

Visit the preview URL for this PR (updated for commit 77f36f2):

https://penumbra-ui-preview--pr1512-turbocrime-fix-refre-0tybq6kk.web.app

(expires Thu, 25 Jul 2024 19:04:28 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 709d729610ef7a6369b23f1cb2b820a60cc685b1

Base automatically changed from turbocrime/fix-hooks to main July 22, 2024 22:58
@VanishMax
Copy link
Contributor

VanishMax commented Aug 30, 2024

@turbocrime @grod220 do we still need this after #1721 and #1510 ?

@turbocrime
Copy link
Contributor Author

react-refresh is distinct from react-hooks

it does look like we missed it in #1721

'react-refresh/only-export-components': 'off',

@turbocrime
Copy link
Contributor Author

i added this because it was in a former lint config, but i think this plugin and its rules aren't actually useful in the codebase. closing PR

@turbocrime turbocrime closed this Aug 30, 2024
@turbocrime
Copy link
Contributor Author

#1750 to remove the unused config

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants