feat(protobuf): #1483: bundle buf into protobuf #1582
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VanishMax
commented
Jul 29, 2024
| * This file re-exports all types from | ||
| * `@buf/penumbra-zone_penumbra.bufbuild_es/penumbra/core/component/component_name/v1/component_name_pb.js` | ||
| * except the duplicated conflicting types (e.g. `GenesisContent`). | ||
| */ |
There was a problem hiding this comment.
TypeScript is complaining if these types are star-exported like this:
That's why I carefully re-exported non-duplicated types only
VanishMax
force-pushed
the
feat/#1483-bundle-buf-into-protobuf
branch
from
99dca7d
to
788bdc1
Compare
|
@turbocrime been fighting this PR whole day – it seems that copying |
|
closed in favor of #1624 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1483
Closes #1503
Re-exports all message types from
@penumbra-zone/protobuf/types.It doesn't, for now, bundle those types into the
protobufpackage. Users still need to install peer dependencies from@buf.