Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Truncate overly long balances #568

Closed
wants to merge 1 commit into from
Closed

Truncate overly long balances #568

wants to merge 1 commit into from

Conversation

jessepinho
Copy link
Contributor

@jessepinho jessepinho commented Feb 17, 2024 •
edited
Loading

Found while investigating #524

Before (note the overflowing penumbra balance)

image

After

image

@jessepinho jessepinho marked this pull request as ready for review February 17, 2024 02:49
grod220
grod220 approved these changes Feb 19, 2024
View reviewed changes
Copy link
Collaborator

@grod220 grod220 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we also get a hover tooltip or something that displays the full amount if it's truncated and hovered for a few seconds? I can make another issue if it's out of scope for now.

@hdevalence
Copy link
Member

The dropdown should be patched to eliminate the "Token Name" column entirely, now that we have a component for rendering the balance and token symbol in one.

@jessepinho
Copy link
Contributor Author

superseded by v2 library

@jessepinho jessepinho closed this Aug 15, 2024
@jessepinho jessepinho deleted the jessepinho/web-524-asset-selector branch August 15, 2024 06:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grod220 grod220 grod220 approved these changes

@turbocrime turbocrime Awaiting requested review from turbocrime

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jessepinho @hdevalence @grod220