fix: Don't free borrowed string slices in Value.deinit #9
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The
initStringfunction stores borrowed slices, not owned copies. Previously,deinittried to free these slices, causing crashes when they pointed to string literals, template source, or user data.This change makes
deinitonly free container memory (arrays, objects) while leaving string memory management to the caller.The Problem
The Solution
Users who need owned strings should use
allocator.dupe()and manage cleanup with arena allocators: