EVEREST-859 | Ensure backups are deleted in foreground during clean-up #440
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mayankshah1607
requested review from
recharte,
oksana-grishchenko and
michal-kralik
as code owners
mayankshah1607
force-pushed
the
EVEREST-859
branch
from
909f52e
to
da673c4
Compare
michal-kralik
approved these changes
Jun 27, 2024
oksana-grishchenko
approved these changes
Jun 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGE DESCRIPTION
Problem:
EVEREST-859
When uninstalling Everest via the CLI, the DB gets deleted before the backups can be cleaned-up properly
Cause:
We're not setting the
foregroundDeletionfinaliser.Solution:
Set the finalizer at the time of performing the cleanup. Currently, the finalizers are added from different places (like from the API server). With this approach, we can unify the clean-up process, so that we don't have to explicitly add finalizers from the API server.
CHECKLIST
Jira
Tests