EVEREST-1628 Do not use db.spec.backup.enabled #656
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mayankshah1607
approved these changes
Feb 12, 2025
Co-authored-by: Mayank Shah <[email protected]>
maxkondr
approved these changes
Feb 12, 2025
oksana-grishchenko
merged commit 6db98d6
into
EVEREST-1625-fix-pitr-options-are-not-available
5 checks passed
oksana-grishchenko
deleted the
EVEREST-1628-deprecate-db-spec-backup-enabled
branch
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not use db.spec.backup.enabled
Problem:
EVEREST-1628
The field
db.spec.backup.enabledis confusing, Everest basically doesn't have such a feature as disabling backups, the field was using instead of checking the number of schedules.Solution:
Instead of using
db.spec.backup.enabledEverest looks at the number of schedules which keeps the logic.Related pull requests
CHECKLIST
Helm chart
Jira
Tests