-
Notifications
You must be signed in to change notification settings - Fork 151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding Recommended Labels #1776
base: main
Are you sure you want to change the base?
Conversation
|
commit: eea5881 |
@cshiv thank you for this PR. I only worry about the version label, because it needs to be updated with every release. @nmarukovich could you please update our Makefile to update this label automatically with |
I do not like the version label as well because in our official doc to update operator you need to update CRDs, RBAC and then just patch the image in percona-server-mongodb-operator deployment. Now, we need to update the version label as well. I do not like it. |
CHANGE DESCRIPTION
Problem:
Short explanation of the problem.
Labels could be improved by using standard and recommended labels.
Cause:
Short explanation of the root cause of the issue if applicable.
Solution:
Short explanation of the solution we are providing with this PR.
Adding recommended labels give good visibility.
Changes below doesn't have any functional impact. I am not sure if I need to add any test cases. Kindly advise. I have kept checklist empty for now.
CHECKLIST
Jira
Needs Doc
) and QA (Needs QA
)?Tests
compare/*-oc.yml
)?Config/Logging/Testability