Fix misleading error messages #5297
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the upgrade process fails due to missing
either one of the files, innodb_index_stats.ibd
and innodb_table_stats.ibd, the same misleading
error was logged: "Error in renaming
mysql_index_stats_ibd".
To correctly log the error, separate the messages
for missing innodb_{index,table}_stats.ibd files
to two variables, and use the corresponding
variable during upgrade process.
All new code of the whole pull request, including
one or several files that are either new files or
modified ones, are contributed under the BSD-new
license. I am contributing on behalf of my
employer Amazon Web Services, Inc.
HashimSyedUBC
force-pushed
the
fix-misleading-error-message
branch
from
839681e to
75c4a34
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the upgrade process fails due to missing either one of the files, innodb_index_stats.ibd and innodb_table_stats.ibd, the same misleading error was logged: "Error in renaming mysql_index_stats_ibd".
To correctly log the error, separate the messages for missing innodb_{index,table}_stats.ibd files to two variables, and use the corresponding variable during upgrade process.
All new code of the whole pull request, including one or several files that are either new files or modified ones, are contributed under the BSD-new license. I am contributing on behalf of my employer Amazon Web Services, Inc.