-
Notifications
You must be signed in to change notification settings - Fork 481
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PS-9533 [8.0]: Introduce cmake option to enable probuilds #5514
Conversation
|
configure.cmake
Outdated
IF(WITH_PERCONA_PROBUILD OR PRO_BUILD) | ||
SET(HAVE_PERCONA_PROBUILD 1) | ||
ENDIF() | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is waht I did for pxb
+OPTION(PROBUILD "Build Percona XtraBackup Pro variant" OFF)
+IF (PROBUILD)
+ SET(XTRABACKUP_SUFFIX "-pro")
+ ADD_DEFINITIONS(-DPROBUILD)
+ENDIF()
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also I used the cmake option PROBUILD. Better to use same name across all products.
Or if you feel -DPERCONA_PROBUILD=1 is better, I will change it in next release.
@percona-ysorokin your thoughts?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@satya-bodapati I followed WITH_VALGRIND
and WITH_PERCONA_TELEMETRY
style.
I also added PROBUILD
option (in Jira there was PRO_BUILD
but probably you changed it later) which is equal to WITH_PERCONA_PROBUILD
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah, I changd it may be. so i am using -DPROBUILD=1 for cmake and within source #ifdef PROBUILD
Add `WITH_PERCONA_PROBUILD` cmake option that enables pro features. The`PRO_BUILD` cmake option is an alias for `WITH_PERCONA_PROBUILD`. From source code we have to use `#ifdef HAVE_PERCONA_PROBUILD` for pro features.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Add
WITH_PERCONA_PROBUILD
cmake option that enables pro features.The
PROBUILD
cmake option is an alias forWITH_PERCONA_PROBUILD
.From source code we have to use
#ifdef HAVE_PERCONA_PROBUILD
for pro features.