Skip to content
This repository has been archived by the owner on Aug 24, 2022. It is now read-only.

PMM-5967 Bind-IP for agent listeners #160

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

Conversation

pavhl
Copy link

@pavhl pavhl commented May 19, 2020

@it-percona
Copy link

it-percona commented May 19, 2020

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link

codecov bot commented May 19, 2020

Codecov Report

Merging #160 into master will decrease coverage by 0.01%.
The diff coverage is 85.71%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #160      +/-   ##
==========================================
- Coverage   67.01%   66.99%   -0.02%     
==========================================
  Files          62       62              
  Lines        5908     5912       +4     
==========================================
+ Hits         3959     3961       +2     
- Misses       1695     1697       +2     
  Partials      254      254              
Flag Coverage Δ
#cover 65.07% <100.00%> (-0.26%) ⬇️
#crosscover 66.99% <85.71%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
commands/run.go 0.00% <0.00%> (ø)
agents/supervisor/supervisor.go 72.87% <100.00%> (+0.14%) ⬆️
config/config.go 83.81% <100.00%> (+0.13%) ⬆️
agents/mongodb/internal/profiler/sender/sender.go 79.36% <0.00%> (-3.18%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 95e76b4...a47c57b. Read the comment docs.

@BupycHuk
Copy link
Member

hi @Crash129 thank you for your PR, but probably it should be done other way. We already have address of the node on backend side and it can be used from there..
We will discuss it with our PO and back to you. Thank you.

@AlekSi AlekSi removed their request for review February 17, 2021 08:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants