Skip to content

PMM-14569: Fix for the new MongoDB Backup details dashboard #1031

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
peterSirotnak merged 1 commit into from
Jan 6, 2026
Merged

PMM-14569: Fix for the new MongoDB Backup details dashboard #1031

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions tests/dashboards/verifyMongodbPbmDashboard_test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,16 +34,16 @@ Data(backupTypes).Scenario('PMM-T2036 - Verify MongoDB PBM dashboard @nightly @g
await backupAPI.waitForBackupFinish(null, `test_schedule_pbm_${current}`, 90);

// Test
const url = I.buildUrlWithParams(dashboardPage.mongodbPBMDetailsDashboard.url, {
const url = I.buildUrlWithParams(dashboardPage.mongodbBackupDetailsDashboard.url, {
from: 'now-5m',
cluster: current.cluster,
});

I.amOnPage(url);
dashboardPage.waitForDashboardOpened();
await dashboardPage.mongodbPBMDetailsDashboard.verifyBackupConfiguredValue('Yes');
await dashboardPage.mongodbPBMDetailsDashboard.verifyPitrEnabledValue(current === 'BACKUP_MODE_PITR' ? 'Yes' : 'No');
await dashboardPage.mongodbBackupDetailsDashboard.verifyBackupConfiguredValue('YES');
await dashboardPage.mongodbBackupDetailsDashboard.verifyPitrEnabledValue(current === 'BACKUP_MODE_PITR' ? 'ON' : 'OFF');
await dashboardPage.expandEachDashboardRow();
await dashboardPage.verifyMetricsExistence(dashboardPage.mongodbPBMDetailsDashboard.metrics);
await dashboardPage.verifyMetricsExistence(dashboardPage.mongodbBackupDetailsDashboard.metrics);
await dashboardPage.verifyThereAreNoGraphsWithoutData();
});
4 changes: 2 additions & 2 deletions tests/pages/dashboardPage.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ const PmmHealthDashboard = require('./dashboards/experimental/pmmHealthDashboard
const HomeDashboard = require('./dashboards/homeDashboard');
const PostgresqlTopQueriesDashboard = require('./dashboards/pgsql/postgresqlTopQueriesDashboard');
const PostgresqlInstancesOverviewExtendedDashboard = require('./dashboards/pgsql/postgresqlInstancesOverviewExtendedDashboard');
const MongodbPBMDetailsDashboard = require('./dashboards/mongodb/mongodbPBMDetailsDashboard');
const MongodbBackupDetailsDashboard = require('./dashboards/mongodb/mongodbBackupDetailsDashboard');
const PostgresqlInstanceOverviewDashboard = require('./dashboards/pgsql/postgresqlInstanceOverviewDashboard');
const PostgresqlInstanceSummaryDashboard = require('./dashboards/pgsql/postgresqlInstanceSummaryDashboard');
const PostgresqlCheckpointDashboard = require('./dashboards/pgsql/postgresqlCheckpointDashboard');
Expand Down Expand Up @@ -345,7 +345,7 @@ module.exports = {
],
},
postgresqlInstanceOverviewDashboard: PostgresqlInstanceOverviewDashboard,
mongodbPBMDetailsDashboard: MongodbPBMDetailsDashboard,
mongodbBackupDetailsDashboard: MongodbBackupDetailsDashboard,
mongodbOverviewDashboard: {
url: 'graph/d/mongodb-instance-summary/mongodb-instance-summary',
metrics: [
Expand Down
21 changes: 12 additions & 9 deletions ...rds/mongodb/mongodbPBMDetailsDashboard.js → .../mongodb/mongodbBackupDetailsDashboard.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,19 +1,22 @@
class MongodbPBMDetailsDashboard {
class MongodbBackupDetailsDashboard {
constructor() {
this.url = 'graph/d/mongodb-pbm-details/mongodb-pbm-details';
this.url = 'graph/d/mongodb-backup-details/mongodb-backup-details';
this.elements = {
backUpConfiguredValue: locate('//section[contains(@data-testid, "Backup Configured")]//div[@data-testid="data-testid panel content"]//span'),
pitrEnabledValue: locate('//section[contains(@data-testid, "PITR Enabled")]//div[@data-testid="data-testid panel content"]//span'),
pitrEnabledValue: locate('//section[contains(@data-testid, "PITR Status")]//div[@data-testid="data-testid panel content"]//span'),
refresh: locate('//button[contains(@data-testid, "RefreshPicker run button")]'),
};
this.metrics = [
'Backup Configured',
'PITR Status',
'Backup Agents',
'Last Successful Backup',
'Backup Agent Summary',
'Backup Agent Status',
'PITR Enabled',
'Backup Size',
'Backup Duration',
'Backup agent status over time',
'Backup history',
'Last Successful Backup',
'Backup Sizes',
'Backup Duration',
];
}

Expand Down Expand Up @@ -41,5 +44,5 @@ class MongodbPBMDetailsDashboard {
}
}

module.exports = new MongodbPBMDetailsDashboard();
module.exports.MongodbPBMDetailsDashboard = MongodbPBMDetailsDashboard;
module.exports = new MongodbBackupDetailsDashboard();
module.exports.MongodbBackupDetailsDashboard = MongodbBackupDetailsDashboard;