Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## v3 #4848 +/- ##
==========================================
+ Coverage 45.95% 46.00% +0.05%
==========================================
Files 365 366 +1
Lines 38223 38394 +171
==========================================
+ Hits 17564 17665 +101
- Misses 18969 19034 +65
- Partials 1690 1695 +5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
JiriCtvrtka
force-pushed
the
PMM-14577-CVEs-fix
branch
from
8ea33e0 to
fc26b21
Compare
go.mod
Outdated
| replace github.com/go-openapi/spec => github.com/JiriCtvrtka/spec v0.0.0-20251222101011-485c12f10ee3 | ||
|
|
||
| replace github.com/go-openapi/spec => github.com/Percona-Lab/spec v0.21.0-percona | ||
| replace github.com/alecthomas/kingpin/v2 => github.com/Percona-Lab/kingpin/v2 v2.0.0-20251219125400-95ff74a47c0a | ||
|
|
||
| replace github.com/alecthomas/kingpin/v2 => github.com/Percona-Lab/kingpin/v2 v2.4.0-percona | ||
|
|
||
| replace golang.org/x/crypto => github.com/percona-lab/crypto v0.0.0-20231108144114-756dfb24eaf2 | ||
| replace golang.org/x/crypto => github.com/percona-lab/crypto v0.0.0-20251219125031-82d8ba2cda22 |
There was a problem hiding this comment.
Before merge of PR all will be replaced with proper commit (after those are merged).
go.mod
Outdated
| // go get -v github.com/percona/saas@latest | ||
|
|
||
| replace github.com/grpc-ecosystem/go-grpc-prometheus => github.com/Percona-Lab/go-grpc-prometheus v0.0.0-20230116133345-3487748d4592 | ||
| replace github.com/go-openapi/spec => github.com/JiriCtvrtka/spec v0.0.0-20251222101011-485c12f10ee3 |
There was a problem hiding this comment.
I dont have permissions to this repo. This is only for now. Once finished it will be replaced with proper commit in Percona spec repo.
There was a problem hiding this comment.
I believe we have a new version now.
| @@ -0,0 +1,389 @@ | |||
| // Copyright (C) 2023 Percona LLC | |||
There was a problem hiding this comment.
if this is copied - should we keep their license?
There was a problem hiding this comment.
This file contains mainly code from Percona fork itself. It is bare minimum to make PMM work with upstream one. So I think it this case it is fine.
JiriCtvrtka
requested review from
BupycHuk and
maxkondr
and removed request for
a team
3 participants
PMM-14577
PMM Dump PR: percona/pmm-dump#343
Spec: Percona-Lab/spec#7