-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PG-1025 Doc update for PG 17 and release notes #664
base: 17
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM though I cannot find Everest mentioned. Can we put the Everest somewhere?
Also, is there a chance to mention the Percona Squad for PG already in the release notes? https://squad.percona.com/pg
@janwieremjewicz please advise in what context do you want Everest mentioned? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than 2 comments LGTM
docs/release-notes-v17.0.md
Outdated
|
||
This release of Percona Distribution for PostgreSQL is based on **Percona Server for PostgreSQL 17** - a binary compatible drop in replacement of [PostgreSQL 17 :octicons-link-external-16:](https://www.postgresql.org/docs/17/release-17.html). Percona Server for PostgreSQL 17 extends the Storage Manager API to hook in custom storage managers and introduce the encryption of indexes (experimental feature) as part of the Transparent Data Encryption (TDE) solution. | ||
|
||
Both Percona Server for PostgreSQL 17 and PostgreSQL Community 17 function identically enabling you to migrate from one to another. However, index-level encryption is available only with Percona Server for PostgreSQL. So if you encrypted indexes, you cannot switch to the upstream PostgreSQL without losing this data. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would use a softer statement, pointing to the need to migrate the migration to the method supported on Community edition before migrating to Community PostgreSQL
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reworded
docs/release-notes-v17.0.md
Outdated
|
||
## Release Highlights | ||
|
||
Percona Distribution for PostgreSQL 17 features a lot of new functionalities and enhancements to performance, replication, monitoring, developer experience and more. Among them are the following: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should give what's due to the upstream here pointing that these come with PostgreSQL 17 comes packed with these improvements and that Percona Distribution gets all the same benefits plus the extension of the API from Percona
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated
4efb54a
to
00c9c0d
Compare
Updated wording for PSPG Updated components versions
00c9c0d
to
373291b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than the comment LGTM
docs/postgresql-server.md
Outdated
@@ -5,10 +5,8 @@ Percona Server for PostgreSQL is a binary-compatible, drop-in replacement for Po | |||
* Storage Manager (SMGR) API Exposure: Allows PostgreSQL extensions to integrate custom storage managers. This change was inspired by the [patchset](https://www.postgresql.org/message-id/flat/CAJ7c6TOqqrzjYsU6LgDkcJ0yVgzdkx2juJjgAjzP2jPOpZ1qUA%40mail.gmail.com#8e68cfc57fcac14c8e24b00b41e61baf) introduced to the community. | |||
* WAL Read/Write API Exposure to hook into WAL read and write functions. | |||
|
|||
These modifications provide index-level and WAL encryption of indexes via the `pg_tde` extension. Note that these encryption features are experimental and under active development. | |||
These modifications are the preparations to provide index-level and WAL encryption of indexes via the [`pg_tde` :octicons-link-external-16:](https://percona-lab.github.io/pg_tde/main/) extension. These encryption features are still under active development and are planned for future releases. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we rephrase to say that these changes are not impacting on existing use cases unless a specific pg_tde extension build is used?
These changes can potentially be only used by opt-in to a tech preview of such a build.
Phrasing it in the current fashion suggests that the patch is under active development while the reality is that the extension is
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
docs/release-notes-v17.0.md
Outdated
|
||
We are pleased to announce the launch of Percona Distribution for PostgreSQL 17.0.1 - a solution with the collection of tools from PostgreSQL community that are tested to work together and serve to assist you in deploying and managing PostgreSQL. The aim of Percona Distribution for PostgreSQL is to address the operational issues like High-Availability, Disaster Recovery, Security, Observability, Spatial data handling, Performance and Scalability and others that enterprises are facing. | ||
|
||
This release of Percona Distribution for PostgreSQL is based on **Percona Server for PostgreSQL 17.0.1** - a binary compatible drop in replacement of [PostgreSQL Community 17.0 :octicons-link-external-16:](https://www.postgresql.org/docs/17/release-17.html). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we add "open source"? as in "a binary compatible, open source, drop in ...
a5aeaa9
to
86f2ba5
Compare
No description provided.