-
Notifications
You must be signed in to change notification settings - Fork 333
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update code in nl2sql.ipynb
notebook - Changed the approach to explain the SQL tables to the model
#10
Update code in nl2sql.ipynb
notebook - Changed the approach to explain the SQL tables to the model
#10
Conversation
Notice that GitHub gets confused by the markdown in the system prompt, and it does not render the code properly in the PR description. |
ef7e483
to
c917607
Compare
I rebased on top of the latest additions to |
Hi @fmquaglia, As you know, this notebook is part of a course, and it’s just a basic, initial approach to creating an NL2SQL solution. In a more advanced lesson, we have this notebook: However, I prefer to keep this more basic and somewhat incorrect approach here, and introduce the more accurate method later when the students have a stronger foundation of knowledge. |
Just figured that we can upload the notebook with a different name, and with some explanations in the header, explaining that this is a better solution. rename the notebook to: 1_2b-Easy_NL2SQL.ipynb. and please, add a by line in the header with your name and a link to your github profile, or linked profile, the one you prefer. |
@peremartra I totally missed this message. I'll try to have it done as you suggest by the end of this week, sir. Thank you! |
nl2sql.ipynb
notebook - Changed the approach to explain the SQL tables to the modenl2sql.ipynb
notebook - Changed the approach to explain the SQL tables to the model
My Fault @fmquaglia! Thanks to you, waiting for you modifications :-) |
Changed the approach to explain the SQL tables to the model, using a domain specific language already understood by the model. This results in a more compact system prompt that still allows for a more nuanced description of the data model. This should result in less tokens consumed by the system prompts and better maintainability allowing for a richer data definition.
c917607
to
cf7b36b
Compare
Renamed the NL2SQL notebook to a more descriptive filename and updated the author information within the notebook. Added a note about DBML to explain its use in database descriptions.
@peremartra Sorry, my wife called me to have dinner, and I completely forgot to send you a comment letting you know that what you requested has been done. Man, thanks for letting me contribute to this project. It makes me happy. Thank you! |
[image: image.png]
Thanks to you Fabricio!
…On Mon, Oct 7, 2024 at 12:31 PM Fabricio Quagliariello < ***@***.***> wrote:
@peremartra <https://github.com/peremartra> Sorry, my wife called me to
have dinner, and I completely forgot to send you a comment letting you know
that what you requested has been done. Man, thanks for letting me
contribute to this project. It makes me happy. Thank you!
—
Reply to this email directly, view it on GitHub
<#10 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABX24ZSAME62QEX67227IZ3Z2JPI5AVCNFSM6AAAAABC5PYZV2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGOJWGU2DANZXGY>
.
You are receiving this because you were mentioned.Message ID:
<peremartra/Large-Language-Model-Notebooks-Course/pull/10/c2396540776@
github.com>
|
Hi Fabricio, I added a link to the notebook in the readme.md of the course,
and i'll promote the notebook on likedin and twitter in the next days,
Thanks for the contribution!
…On Mon, Oct 7, 2024 at 10:34 PM Pere Martra ***@***.***> wrote:
[image: image.png]
Thanks to you Fabricio!
On Mon, Oct 7, 2024 at 12:31 PM Fabricio Quagliariello <
***@***.***> wrote:
> @peremartra <https://github.com/peremartra> Sorry, my wife called me to
> have dinner, and I completely forgot to send you a comment letting you know
> that what you requested has been done. Man, thanks for letting me
> contribute to this project. It makes me happy. Thank you!
>
> —
> Reply to this email directly, view it on GitHub
> <#10 (comment)>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/ABX24ZSAME62QEX67227IZ3Z2JPI5AVCNFSM6AAAAABC5PYZV2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGOJWGU2DANZXGY>
> .
> You are receiving this because you were mentioned.Message ID:
> <peremartra/Large-Language-Model-Notebooks-Course/pull/10/c2396540776@
> github.com>
>
|
It is using a domain-specific language already understood by the model. This results in a more compact system prompt that allows for a more nuanced data model description. This should result in fewer tokens consumed by the system prompts and better maintainability, allowing for a richer data definition.
This might not be ideal for an educational exercise because it adds to the cognitive load (Wait... what? What is this DBML thing?), but I figured I would show it to you, anyway.
From
To
"""
})
...