Skip to content

Commit

Permalink
pmrep conf: use bpf instead of bcc pmda for proc net metrics
Browse files Browse the repository at this point in the history
Now with the new BPF PMDA netatop module available switch the pmrep
per-process proc-activity, proc-net, and proc-net-ext metricsets to
use it. Also replace the earlier call counts with the more commonly
used packet counts in proc-net-ext.

Lastly, remove commented out bcc.proc.io.total reference from proc-io,
the metricset already includes the proc.io.total_bytes derived metric.
  • Loading branch information
myllynen committed Feb 16, 2024
1 parent 79beed0 commit 04377af
Showing 1 changed file with 10 additions and 11 deletions.
21 changes: 10 additions & 11 deletions src/pmrep/conf/proc.conf
Original file line number Diff line number Diff line change
Expand Up @@ -76,9 +76,9 @@ iotot.label = IO KB/s
iotot.formula = instant(proc.io.read_bytes) + instant(proc.io.write_bytes) - instant(proc.io.cancelled_write_bytes)
iotot.unit = KB/s
iotot.width = 8
net = bcc.proc.net.total.bytes
net = bpf.proc.net.total.bytes
net.label = Net KB/s
net.formula = bcc.proc.net.tcp.recv.bytes + bcc.proc.net.tcp.send.bytes + bcc.proc.net.udp.recv.bytes + bcc.proc.net.udp.send.bytes
net.formula = bpf.proc.net.tcp.recv.bytes + bpf.proc.net.tcp.send.bytes + bpf.proc.net.udp.recv.bytes + bpf.proc.net.udp.send.bytes
net.unit = KB/s
net.width = 8

Expand Down Expand Up @@ -194,7 +194,6 @@ proc.io.write_bytes = ,,KB/s,,
proc.io.total_bytes = ,,KB/s,,
proc.io.cancelled_write_bytes = ,,KB/s,,
proc.psinfo.delayacct_blkio_time = ,,,,
#bcc.proc.io.total = ,,KB/s,,

[proc-io-ext]
instinfo = no
Expand All @@ -209,19 +208,19 @@ proc.io.syscw = ,,,,
instinfo = no
unitinfo = yes
precision = 2
bcc.proc.net.tcp.recv.bytes = TCP recv,,KB/s,,
bcc.proc.net.tcp.send.bytes = TCP send,,KB/s,,
bcc.proc.net.udp.recv.bytes = UDP recv,,KB/s,,
bcc.proc.net.udp.send.bytes = UDP send,,KB/s,,
bpf.proc.net.tcp.recv.bytes = TCP recv,,KB/s,,
bpf.proc.net.tcp.send.bytes = TCP send,,KB/s,,
bpf.proc.net.udp.recv.bytes = UDP recv,,KB/s,,
bpf.proc.net.udp.send.bytes = UDP send,,KB/s,,

[proc-net-ext]
instinfo = no
unitinfo = yes
precision = 0
bcc.proc.net.tcp.recv.calls = ,,,,
bcc.proc.net.tcp.send.calls = ,,,,
bcc.proc.net.udp.recv.calls = ,,,,
bcc.proc.net.udp.send.calls = ,,,,
bpf.proc.net.tcp.recv.packets = TCP recv pkts,,,,
bpf.proc.net.tcp.send.packets = TCP send pkts,,,,
bpf.proc.net.udp.recv.packets = UDP recv pkts,,,,
bpf.proc.net.udp.send.packets = UDP send pkts,,,,

[proc-children]
instinfo = no
Expand Down

0 comments on commit 04377af

Please sign in to comment.