Skip to content

Commit

Permalink
pmdalinux: remove spurious init-to-zero in hugepage metrics, fix QA
Browse files Browse the repository at this point in the history
  • Loading branch information
natoscott committed Feb 26, 2024
1 parent 9de1305 commit 0b759b1
Show file tree
Hide file tree
Showing 2 changed files with 68 additions and 2 deletions.
69 changes: 68 additions & 1 deletion qa/1788.out
Original file line number Diff line number Diff line change
@@ -1,2 +1,69 @@
QA output created by 1788
[skeleton from qa/new, replace me]
== Checking hugepages metric values - sysfs-hugepages-001.tgz

mem.hugepages.free
inst [0 or "2048kB"] value 0
inst [1 or "32768kB"] value 327680
inst [2 or "64kB"] value 0
inst [3 or "1048576kB"] value 0

mem.hugepages.overcommit
inst [0 or "2048kB"] value 0
inst [1 or "32768kB"] value 0
inst [2 or "64kB"] value 0
inst [3 or "1048576kB"] value 0

mem.hugepages.pagesize
inst [0 or "2048kB"] value 2048
inst [1 or "32768kB"] value 32768
inst [2 or "64kB"] value 64
inst [3 or "1048576kB"] value 1048576

mem.hugepages.reserved
inst [0 or "2048kB"] value 0
inst [1 or "32768kB"] value 0
inst [2 or "64kB"] value 0
inst [3 or "1048576kB"] value 0

mem.hugepages.surplus
inst [0 or "2048kB"] value 8192
inst [1 or "32768kB"] value 0
inst [2 or "64kB"] value 5760
inst [3 or "1048576kB"] value 0

mem.hugepages.totalsize
inst [0 or "2048kB"] value 8192
inst [1 or "32768kB"] value 327680
inst [2 or "64kB"] value 6400
inst [3 or "1048576kB"] value 0

== done

== Checking hugepages metric values - sysfs-hugepages-002.tgz

mem.hugepages.free
inst [0 or "2048kB"] value 4096000
inst [3 or "1048576kB"] value 104857600

mem.hugepages.overcommit
inst [0 or "2048kB"] value 0
inst [3 or "1048576kB"] value 0

mem.hugepages.pagesize
inst [0 or "2048kB"] value 2048
inst [3 or "1048576kB"] value 1048576

mem.hugepages.reserved
inst [0 or "2048kB"] value 16384
inst [3 or "1048576kB"] value 0

mem.hugepages.surplus
inst [0 or "2048kB"] value 8192
inst [3 or "1048576kB"] value 0

mem.hugepages.totalsize
inst [0 or "2048kB"] value 4096000
inst [3 or "1048576kB"] value 104857600

== done

1 change: 0 additions & 1 deletion src/pmdas/linux/sysfs_hugepages.c
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,6 @@ refresh_sysfs_hugepages(pmInDom indom)
for (i=0; i < HUGEPAGES_METRIC_COUNT; i++) {
if (strncmp(hugepage_fields[i], h, hlen) == 0) {
hugepage->values[i] = strtoull(strvalue, NULL, 0);
hugepage->values[i] = 0;
break;
}
}
Expand Down

0 comments on commit 0b759b1

Please sign in to comment.