ci: add Debian 12, drop Ubuntu 16 and Fedora 35

Add the new Debian 'bookworm' release (12), drop two long-EOL releases.

.github/workflows/ci.yml

@@ -21,7 +21,7 @@ jobs:
       matrix:
         include:
 # default platforms for CI in the performancecopilot/pcp repo
-          - {platform: ubuntu1604-container,      os: ubuntu-20.04, experimental: false}
+          - {platform: ubuntu1804-container,      os: ubuntu-20.04, experimental: false}
           - {platform: ubuntu1804-i386-container, os: ubuntu-20.04, experimental: false}
           - {platform: ubuntu2004-container,      os: ubuntu-20.04, experimental: false}
           - {platform: ubuntu2204-container,      os: ubuntu-20.04, experimental: false}
@@ -32,6 +32,7 @@ jobs:
 # other platforms that may be used for testing in developer repos
 #          - {platform: debian10-container,        os: ubuntu-20.04, experimental: false}
 #          - {platform: debian11-container,        os: ubuntu-20.04, experimental: false}
+#          - {platform: debian12-container,        os: ubuntu-20.04, experimental: false}
 #          - {platform: ubuntu1804-container,      os: ubuntu-20.04, experimental: false}
 #          - {platform: ubuntu2004,                os: ubuntu-20.04, experimental: false}
 #          - {platform: ubuntu2204,                os: ubuntu-20.04, experimental: false}

.github/workflows/qa.yml

@@ -23,14 +23,13 @@ jobs:
         include:
           - {platform: debian10-container,        os: ubuntu-20.04, experimental: false}
           - {platform: debian11-container,        os: ubuntu-20.04, experimental: false}
-          - {platform: ubuntu1604-container,      os: ubuntu-20.04, experimental: false}
+          - {platform: debian12-container,        os: ubuntu-20.04, experimental: false}
           - {platform: ubuntu1804-container,      os: ubuntu-20.04, experimental: false}
           - {platform: ubuntu1804-i386-container, os: ubuntu-20.04, experimental: false}
           - {platform: ubuntu2004-container,      os: ubuntu-20.04, experimental: false}
           - {platform: ubuntu2004,                os: ubuntu-20.04, experimental: false}
           - {platform: ubuntu2204-container,      os: ubuntu-20.04, experimental: false}
           - {platform: ubuntu2204,                os: ubuntu-22.04, experimental: false}
-          - {platform: fedora35-container,        os: ubuntu-20.04, experimental: false}
           - {platform: fedora36-container,        os: ubuntu-20.04, experimental: false}
           - {platform: fedora37-container,        os: ubuntu-20.04, experimental: false}
           - {platform: fedora38-container,        os: ubuntu-20.04, experimental: false}

.github/workflows/release.yml

@@ -21,11 +21,10 @@ jobs:
           # different packages than the stock Ubuntu releases
           - {platform: debian10-container,        os: ubuntu-20.04}
           - {platform: debian11-container,        os: ubuntu-20.04}
-          - {platform: ubuntu1604-container,      os: ubuntu-20.04}
+          - {platform: debian12-container,        os: ubuntu-20.04}
           - {platform: ubuntu1804-container,      os: ubuntu-20.04}
           - {platform: ubuntu2004-container,      os: ubuntu-20.04}
           - {platform: ubuntu2204-container,      os: ubuntu-20.04}
-          - {platform: fedora35-container,        os: ubuntu-20.04}
           - {platform: fedora36-container,        os: ubuntu-20.04}
           - {platform: fedora37-container,        os: ubuntu-20.04}
           - {platform: fedora38-container,        os: ubuntu-20.04}

build/ci/README.md

@@ -9,7 +9,7 @@ Workflow descriptions are located in `.github/workflows`, platform specific PCP
 
 ## Reproducing test failures
 ```
-build/ci/ci-run.py ubuntu2004-container|fedora34-container|centos8-container|... reproduce
+build/ci/ci-run.py ubuntu2004-container|fedora38-container|centos9-container|... reproduce
 ```
 
 ## Debugging
@@ -20,13 +20,6 @@ Include the following action in a workflow, and connect via SSH:
   uses: mxschmitt/action-tmate@v2
 ```
 
-## Notes
-Ubuntu 16.04 runs in a container even though there is a native Ubuntu 16.04 VM on GitHub actions, because:
-* the `ci-run.py` script requires Python >= 3.6, but
-* Ubuntu 16.04 contains Python 3.5 in the official repositories, and
-* if a more recent version is installed using the `actions/setup-python` action, the included setuptools doesn't include the `--install-layout` option (this option is included only in the official Debian Python builds),
-* however, this option is required by the PCP Python build.
-
 # Artifactory
 ## Recalculate and sign package metadata
 The repository metadata needs to be signed again after each change to the repository.

build/ci/platforms/debian10-container.yml

@@ -42,7 +42,7 @@ tasks:
     sudo -i -u pcpqa ./check -TT -g sanity -x not_in_ci -x not_in_container |& tee ../artifacts/test/test.log
   qa: |
     set -o pipefail
-    DEFAULT_PCP_QA_ARGS="-x x11 -x remote -x not_in_ci  -x not_in_container"
+    DEFAULT_PCP_QA_ARGS="-x x11 -x remote -x not_in_ci -x not_in_container"
     sudo -i -u pcpqa ./check -TT ${PCP_QA_ARGS:-${DEFAULT_PCP_QA_ARGS}} |& tee ../artifacts/test/test.log
   copy_test_artifacts: |
     cp /var/lib/pcp/testsuite/check.timings ../artifacts/test

build/ci/platforms/ubuntu1604-container.yml → build/ci/platforms/debian12-container.yml

@@ -2,26 +2,24 @@ type: container
 
 artifactory:
   package_type: deb
-  deploy_path: /ubuntu/16.04/amd64/pcp
+  deploy_path: /debian/12/amd64/pcp
   params:
-    deb.distribution: xenial
+    deb.distribution: bookwork
     deb.component: main
     deb.architecture: amd64
 
 container:
   containerfile: |
-    FROM docker.io/library/ubuntu:16.04
-    RUN apt-get update && apt-get install -y sudo locales
+    FROM docker.io/library/debian:bookworm
+    RUN apt-get update && apt-get install -y systemd sudo
     RUN useradd --create-home pcpbuild
     RUN echo 'pcpbuild ALL=(ALL) NOPASSWD: ALL' > /etc/sudoers.d/pcpbuild
-    RUN update-locale LANG=C.UTF-8
-    ENV LANG C.UTF-8
 
     # allow services to be started during installation
     # pmcd will create the file /var/lib/pcp/pmns/stdpmid, which is required by QA tests
     RUN printf '#!/bin/sh\nexit 0\n' > /usr/sbin/policy-rc.d
 
-    CMD ["/sbin/init"]
+    CMD ["/bin/systemd"]
 
 tasks:
   setup: |
@@ -36,11 +34,8 @@ tasks:
   install: |
     sudo dpkg -i build/deb/*.deb
     echo 'pcpqa ALL=(ALL) NOPASSWD: ALL' | sudo tee /etc/sudoers.d/pcpqa
-
-    # "invoke-rc.d pmcd start" (inside pcp.postinst.tail hook) doesn't start pmcd on ubuntu 16.04 (works fine on ubuntu 18.04)
-    # make sure it's started here, as pmcd will create the file /var/lib/pcp/pmns/stdpmid, which is required by QA tests
-    sudo systemctl start pmcd
   init_qa: |
+    sudo systemctl start redis
     sudo -i -u pcpqa ./check 002
   qa_sanity: |
     set -o pipefail

qa/admin/package-lists/Debian+12.0+x86_64

@@ -0,0 +1,136 @@
+# PCP required package list for Debian 12 any
+# created by nathans on fedora.localdomain Tue 13 Jun 2023 09:46:08 +1000
+#
+apache2
+apache2-bin
+auditd
+autoconf
+autotools-dev
+avahi-utils
+bash
+bc
+bind9-host
+bison
+bpfcc-tools
+bpftrace
+bsd-mailx
+build-essential
+chrpath
+clang
+coreutils
+Text::CSV_XS cpan
+cppcheck
+cron
+curl
+debhelper
+dh-python
+dpkg-dev
+ed
+flex
+g++
+gawk
+gcc
+gdb
+gfs2-utils
+git
+grep
+iproute2
+libavahi-common-dev
+libbpf1
+libbpf-dev
+libclass-dbi-perl
+libcmocka-dev
+libcoin-dev
+libdbd-mysql-perl
+libdbd-pg-perl
+libdevmapper-dev
+libextutils-autoinstall-perl
+libfile-slurp-perl
+libgl1-mesa-dri
+libibmad-dev
+libibumad-dev
+libicu72
+libjson-perl
+liblist-moreutils-perl
+liblzma-dev
+libncurses-dev
+libncurses5-dev
+libnet-snmp-perl
+libperl5.36
+libpfm4-dev
+libpython3-dev
+libpython3-stdlib
+libqt5svg5-dev
+libreadline-dev
+librrds-perl
+libsasl2-dev
+libsasl2-modules
+libsoqt520-dev
+libspreadsheet-read-perl
+libspreadsheet-readsxc-perl
+libspreadsheet-writeexcel-perl
+libspreadsheet-xlsx-perl
+libsqlite3-0
+libssl-dev
+libsystemd-dev
+libtext-csv-xs-perl
+libtimedate-perl
+libuv1-dev
+libvirt-daemon
+libvirt-daemon-system
+libxml-libxml-perl
+libxml-tokeparser-perl
+libyaml-libyaml-perl
+linux-headers-`uname -r` not4ci
+llvm
+lm-sensors
+make
+man-db
+mandoc
+mariadb-client-core
+memcached
+net-tools
+nmap
+openjdk-17-jre-headless
+openssl
+perl
+perl-modules-5.36
+pkg-config
+postgresql-client-common
+psmisc
+pylint
+python3-all
+python3-all-dev
+python3-bpfcc
+python3-dev
+python3-elasticsearch
+python3-json-pointer
+python3-libvirt
+python3-lxml
+python3-openpyxl
+python3-pil
+python3-prometheus-client
+python3-psycopg2
+python3-pymongo
+python3-requests
+python3-setuptools
+python3-six
+qtbase5-dev
+qtbase5-dev-tools
+qtchooser
+redis-redisearch
+redis-server
+redis-tools
+sasl2-bin
+sed
+smartmontools
+socat
+sysstat
+systemtap-sdt-dev
+time
+unbound
+valgrind
+xfsprogs
+xkb-data
+zabbix-agent
+zlib1g-dev