Skip to content

Commit

Permalink
Merge branch 'main' of github.com:performancecopilot/pcp
Browse files Browse the repository at this point in the history
  • Loading branch information
natoscott committed May 7, 2024
2 parents 1582c66 + 9b5fb9d commit 33d68f8
Show file tree
Hide file tree
Showing 5 changed files with 69 additions and 0 deletions.
13 changes: 13 additions & 0 deletions man/man1/pmcheck.1
Original file line number Diff line number Diff line change
Expand Up @@ -436,6 +436,19 @@ or
options are used, the success or failure of the reconfiguration is
reported on standard output.
.PD
.SH CAVEAT
Some components have prerequisites that demand additional non-PCP services be
installed, configured and operational, e.g. a database server or a key-value
server.
In these cases, probing the status of the non-PCP service may be subject to
some access controls and if
.B pmcheck
is run as a non-root user, then the output from
.B \-s
(the default)
may be incomplete or misleading; in these circumstances, running
.B pmcheck
as root should provide a more accurate report.
.SH PCP ENVIRONMENT
Environment variables with the prefix \fBPCP_\fP are used to parameterize
the file and directory names used by PCP.
Expand Down
9 changes: 9 additions & 0 deletions qa/1684
Original file line number Diff line number Diff line change
Expand Up @@ -21,10 +21,19 @@ _cleanup()
status=0 # success is the default!
trap "_cleanup; exit \$status" 0 1 2 3 15

# quoting, brackets and commas is a Python version thing (yuk)
# seen on vm29 (RHEL 7.9 and Python 2.7.5)
# ('Loading derived metrics from', 'no-such-file')
# ('Failed to load:', 'No such file or directory')
# ('Successfully loaded', 2, 'derived metrics')
#
_filter()
{
sed \
-e "s@$tmp@TMP@g" \
-e "/Loading derived metrics/s/[('),]//g" \
-e "/Failed to load/s/[('),]//g" \
-e "/Successfully loaded/s/[('),]//g" \
# end
}

Expand Down
2 changes: 2 additions & 0 deletions qa/1827
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,8 @@ echo "QA output created by $seq"
. ./common.python

which pcp2openmetrics >/dev/null 2>&1 || _notrun "pcp2openmetrics not installed"
$python -c "from http.server import BaseHTTPRequestHandler, HTTPServer" >/dev/null 2>&1
[ $? -eq 0 ] || _notrun "python import from http.server failed"

_cleanup()
{
Expand Down
42 changes: 42 additions & 0 deletions qa/821.out
Original file line number Diff line number Diff line change
Expand Up @@ -473,6 +473,12 @@ No value(s) available!
mem.util.zswapped
No value(s) available!

mem.vmmemctl.current
value 0

mem.vmmemctl.target
value 0

mem.vmstat.allocstall
value 0

Expand Down Expand Up @@ -3294,6 +3300,12 @@ No value(s) available!
mem.util.zswapped
No value(s) available!

mem.vmmemctl.current
value 0

mem.vmmemctl.target
value 0

mem.vmstat.allocstall
value 0

Expand Down Expand Up @@ -6093,6 +6105,12 @@ No value(s) available!
mem.util.zswapped
No value(s) available!

mem.vmmemctl.current
value 0

mem.vmmemctl.target
value 0

mem.vmstat.allocstall
value 0

Expand Down Expand Up @@ -8855,6 +8873,12 @@ No value(s) available!
mem.util.zswapped
No value(s) available!

mem.vmmemctl.current
value 0

mem.vmmemctl.target
value 0

mem.vmstat.allocstall
No value(s) available!

Expand Down Expand Up @@ -11385,6 +11409,12 @@ No value(s) available!
mem.util.zswapped
No value(s) available!

mem.vmmemctl.current
value 0

mem.vmmemctl.target
value 0

mem.vmstat.allocstall
No value(s) available!

Expand Down Expand Up @@ -13979,6 +14009,12 @@ No value(s) available!
mem.util.zswapped
No value(s) available!

mem.vmmemctl.current
value 0

mem.vmmemctl.target
value 0

mem.vmstat.allocstall
No value(s) available!

Expand Down Expand Up @@ -15882,6 +15918,12 @@ No value(s) available!
mem.util.zswapped
No value(s) available!

mem.vmmemctl.current
value 0

mem.vmmemctl.target
value 0

mem.vmstat.allocstall
No value(s) available!

Expand Down
3 changes: 3 additions & 0 deletions qa/triaged
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,9 @@
Conditional jump or move depends on uninitialised value
at 0x11F1D2: deviattask (deviate.c:340)
but this seems bogus and is not seen elsewhere
1171 openSUSE Leap 15.6 bcc module profile => LLVM ERROR: and no details
1173 Fedora 38 pmdabcc cannot get the ucalls module to work here
1179 openSUSE Leap 15.6 bcc module ustat => bpf: Argument list too long
1210 vm[0-9][0-9] may collide with pmlogger_check and (correctly)
detects presence of /etc/pcp/pmlogger/lock
1290 Debian 1[01] valgrind-reported issues in libpcp_web redis i/o functions
Expand Down Expand Up @@ -126,6 +128,7 @@
1546 FreeBSD 14.0 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=276281
1547 FreeBSD 14.0 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=276281
1549 FreeBSD 14.0 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=276281
1623 FreeBSD 14.0 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=276281
1671 FreeBSD 14.0 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=276281
1793 FreeBSD 14.0 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=276281
# and these ones are just localtime() botched, no Python involved
Expand Down

0 comments on commit 33d68f8

Please sign in to comment.