Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pcp-meminfo: initial commit of PCP implementation of meminfo #1769

Merged

Conversation

mohith-kumar-thummaluru
Copy link
Contributor

pcp meminfo utility has been developed to view the /proc/meminfo data on live as well as on archive data

@natoscott
Copy link
Member

@mohith-kumar-thummaluru thanks for your contribution - I'm away on holiday shortly but will take a closer look when back online.

Copy link
Member

@natoscott natoscott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mohith-kumar-thummaluru Good stuff! Can you look through my notes here and then also add a regression test similar to the one at qa/1398 for pcp-pidstat (will need to create a small, compressed archive or two to go along with the test - see 1398 for an example of that) - thanks!

src/pcp/meminfo/pcp-meminfo.py Outdated Show resolved Hide resolved
src/pcp/meminfo/pcp-meminfo.py Outdated Show resolved Hide resolved
src/pcp/meminfo/pcp-meminfo.py Outdated Show resolved Hide resolved
src/pcp/meminfo/pcp-meminfo.py Outdated Show resolved Hide resolved
src/pcp/meminfo/pcp-meminfo.py Outdated Show resolved Hide resolved
src/pcp/meminfo/pcp-meminfo.py Outdated Show resolved Hide resolved
src/pcp/meminfo/pcp-meminfo.py Outdated Show resolved Hide resolved
src/pcp/meminfo/pcp-meminfo.py Outdated Show resolved Hide resolved
src/pcp/GNUmakefile Show resolved Hide resolved
@mohith-kumar-thummaluru
Copy link
Contributor Author

Thanks for the comments, Scott. Let me fix these and get back to you.

@mohith-kumar-thummaluru
Copy link
Contributor Author

Hi scott,

I have updated the code related changes that you have shared over your notes, and regression tests are not yet done. I'll look into it and update you

Thanks

Signed-off-by: Mohith Kumar Thummaluru <[email protected]>
Signed-off-by: Mohith Kumar Thummaluru <[email protected]>
@natoscott
Copy link
Member

@mohith-kumar-thummaluru thanks - I've made minor changes to QA (please double check) & merging now.

@natoscott natoscott merged commit 3efb5af into performancecopilot:main Aug 1, 2023
18 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants