Addition of pcp2opentelemetry tool #1972
Conversation
There was a problem hiding this comment.
@lmchilton nice work - couple comments inline - also, the packaging side of things is needed below build/rpm too.
| @@ -2269,10 +2269,65 @@ QA output created by 1131 | |||
| --- | |||
|
|
|||
|
|
|||
| # HELP hinv_ncpu number of CPUs in the system | |||
| # HELP hinv_ncpu b'number of CPUs in the system' | |||
There was a problem hiding this comment.
You need to upgrade your PCP python installation (./Makepkgs FTW) - this b'...' issue will be resolved then.
There was a problem hiding this comment.
@natoscott I upgraded the packages, ran configure and make and still the b' issue was still there when I re ran the test?
There was a problem hiding this comment.
Hmm, that is a mystery - its definitely fixed for me (and in CI). I wonder if somehow an older version of the python library is being found somewhere on your system, unexpectedly.
| -e '/^Connection: keep-alive/d' \ | ||
| -e '/ using stream socket$/d' | ||
| } | ||
|
|
There was a problem hiding this comment.
since this pattern is repeated in three or four tests now, let's make a _filter_python_http_reponse shell function in one of the qa/common.xxx files and share it.
There was a problem hiding this comment.
@natoscott should this go in a specific common.xxx file or make a new one?
There was a problem hiding this comment.
@lmchilton lets put it in common.python
Supports translation of pcp metrics into open telemetry format. Supports opentelemetry protocol http json format. Updated relevent qa tests, as well as created a new one (1977) to test the tools http functionality. Added man page and makefile. Contains changes from review comments, including changes to spec and qa files.
lmchilton
force-pushed
the
pcp2opentelemetry-tool
branch
from
dfab591
to
d94a4cc
Compare
Supports translation of pcp metrics into open telemetry format. Supports opentelemetry protocol http json format.
Updated relevent qa tests, as well as created a new one (1977) to test the tools http functionality.
Added man page and makefile.