proc: add amdgpu support #2009
Merged
proc: add amdgpu support #2009
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fberat
force-pushed
the
devel/proc_amdgpu
branch
from
7ebdadb
to
c4f2cca
Compare
|
Rebased on main, description amended. |
|
Looking good Fred. There's something not-quite-right causing the help text to go missing. I haven't been able to pin it down though (there's some tweaks needed in root_proc but that's not enough it seems). I'll send you a patch of what I have, maybe you can see what I'm missing here. We'll also probably need some filtering in common QA routines, similar to the way [hot]proc.smaps.* is done. |
Add per process GPU metrics for AMD GPUs. The data is retrieved from `/proc/<pid>/fdinfo`. The current implementation accumulates data for each process, walking through all file descriptors and looking for drm and amd entries. A future patch may be considered to separate the data per drm client ID. Signed-off-by: Frédéric Bérat <[email protected]>
fberat
force-pushed
the
devel/proc_amdgpu
branch
from
c4f2cca
to
136a5ca
Compare
|
@fberat thanks Fred - I've made some QA fixups on top of this (please double check), but there may be others I've missed (please keep an eye on CI results tomorrow). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a first shot for new AMD GPU process metrics.
This patch collects information retrieved from
/proc/<pid>/fdinfo.The current implementation accumulates data for each process, walking through all file descriptors and looking for drm and amd entries.
A future patch may be considered to separate the data per drm client ID.