Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

proc: Fix resource leak in fdinfo processing #2018

Merged
merged 2 commits into from
Jul 15, 2024

Conversation

fberat
Copy link
Contributor

@fberat fberat commented Jul 12, 2024

Fix coverity reported issues:

  • Close dirp appropriately when returning from refresh_proc_pid_fdinfo.
  • Pass proc_pid_fdinfo_t struct as a pointer to accumulate_proc_fdinfo.

Close dirp appropriately when returning from refresh_proc_pid_fdinfo.
Pass proc_pid_fdinfo_t struct as a pointer to accumulate_proc_fdinfo.

Signed-off-by: Frédéric Bérat <[email protected]>
@natoscott
Copy link
Member

@fberat @kmcdonell I think you both fixed this issue, can you review & see if this PR is still needed? taa.

@kmcdonell
Copy link
Member

The closedir() changes look the same in both commits, but we need some of my other changes (debug, readdir() loop issue) and some of @fberat 's changes (Coverity ones).
Let me try and resolve the conflicts in this PR.

@kmcdonell kmcdonell merged commit 6aafd1b into performancecopilot:main Jul 15, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants