Refactor cdm.js to improve maintainability and fix critical bugs - #150
Merged
Conversation
Reduces code duplication by extracting utility functions for deep cloning, type checking, and error responses. Refactors 19 get* wrapper functions to use a factory pattern, consolidates array flattening logic, and generalizes instance discovery. Fixes 5 critical runtime bugs including variable name typos and incorrect property access. Net reduction of 85 lines while preserving all exports and maintaining backward compatibility. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
k-rister
reviewed
Feb 14, 2026
k-rister
left a comment
k-rister
left a comment
Contributor
There was a problem hiding this comment.
Everything looks pretty good to me except for deepClone...
k-rister
approved these changes
Feb 16, 2026
k-rister
left a comment
k-rister
left a comment
Contributor
There was a problem hiding this comment.
Now I get it :). Using strings to derefence the objects while copying things.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes
Test plan
🤖 Generated with Claude Code