feat: add queue and nic fields to metric_desc.names mapping - #188
Conversation
Add two new keyword fields to the metric_desc.names mapping: - queue: for per-queue DPDK metric breakout (e.g., NIC hardware queues 0-N). Enables --breakout queue to query all queues in a single command instead of embedding the queue ID in the metric type name. - nic: for NIC PCI address identification. Enables --breakout nic to distinguish which physical NIC a port number corresponds to across different DPDK applications on different hosts. These fields support the tool-dpdk telemetry tool's per-queue and per-NIC metric normalization. Without these fields, OpenSearch's strict dynamic mapping rejects documents containing them. Co-authored-by: Cursor <cursoragent@cursor.com>
|
Seems fine to me but @atheurer is the proper authority. |
|
This PR adds two new keyword fields ( Why these fields are needed: Without queue and nic in the OpenSearch mapping, documents containing these labels are silently rejected by the strict dynamic mapping on metric_desc.names. This was confirmed during live testing -- all dpdk metric documents were dropped with: What each field enables:
tool-dpdk PR #3 depends on this PR. The tool-dpdk code already emits queue and nic labels -- they are accepted when the schema includes these fields and silently dropped when it doesn't. The tool-dpdk PR should be merged after this one. Impact on existing tools: None. These are additive keyword fields. No existing tool emits queue or nic labels, so no existing data or queries are affected. The names object is a flat map -- adding new fields does not change the behavior of fields already present. Testing: Verified on a live OVS-DPDK + testpmd + TRex topology (3 hosts, 13 DPDK ports) that:
|
Add two new keyword fields to the metric_desc.names mapping:
queue: for per-queue DPDK metric breakout (e.g., NIC hardware queues 0-N). Enables --breakout queue to query all queues in a single command instead of embedding the queue ID in the metric type name.
nic: for NIC PCI address identification. Enables --breakout nic to distinguish which physical NIC a port number corresponds to across different DPDK applications on different hosts.
These fields support the tool-dpdk telemetry tool's per-queue and per-NIC metric normalization. Without these fields, OpenSearch's strict dynamic mapping rejects documents containing them.