feat: surface partial-run status in get-result-summary (PERFNFV-464) - #206
Merged
Conversation
Adds a GET /api/v1/run/:id/partial-status endpoint (mirrors the existing /benchmark endpoint) that reads the run.partial/ run.dropped-engines fields already added to the v9dev+ run mapping (PR#204) via the existing cdm.getRunData() helper, gracefully defaulting to partial=false/dropped-engines=[] for older CDM versions that predate these fields. get-result-summary.js now fetches this alongside tags/benchmark and prints "partial: yes (N engine(s) dropped)" when applicable, matching the wording bin/result-processor.py already uses for `crucible ls` in the crucible repo -- closing the gap flagged in crucible PR#652's review, where docs/how-benchmark-execution-works.md claimed both `crucible ls` and `crucible get result` surface this, but only the former did. Verified end-to-end: the existing partial=false path against a real indexed run, and the partial=true path against a synthetic run+ iteration doc pair inserted directly into OpenSearch and deleted afterward (a genuinely-indexed partial:true run is hard to produce -- a dropped engine tends to break later pipeline steps before indexing completes).
Merged
3 tasks
atheurer
approved these changes
Aug 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GET /api/v1/run/:id/partial-status, mirroring the existing/benchmarkendpoint, readingrun.partial/run.dropped-engines(already added to the v9dev+ run mapping in PR#204) via the existingcdm.getRunData()helper. Gracefully defaults topartial: false, dropped-engines: []for older CDM versions that predate these fields.get-result-summary.jsfetches this alongsidetags/benchmarkand printspartial: yes (N engine(s) dropped)when applicable — matching the wordingbin/result-processor.pyalready uses forcrucible lsin the crucible repo.crucible lsandcrucible get resultsurface partial-run status, but onlycrucible lsactually did until now.Test plan
crucible get resultpath (partial: false) verified against a real indexed runpartial: truepath verified against a synthetic run+iteration doc pair inserted directly into OpenSearch (deleted afterward) — a genuinely-indexed partial run is hard to produce naturally, since a dropped engine tends to break later pipeline steps before indexing completesnode_modules/.bin/prettier --checkpasses🤖 Generated with Claude Code