feat: use latency class and max aggregation for wakeup-latency - #74
Merged
Conversation
Change the metric descriptor from class=count to class=latency and add default-aggregation=max. This ensures that when multiple engines report wakeup latency, the aggregated result is the maximum across engines (worst-case latency) rather than the sum. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
atheurer
approved these changes
Jul 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
class: counttoclass: latencywithdefault-aggregation: maxThis is the first benchmark migration for CDM default-aggregation support (CDM PR#202). The
default-aggregationfield is accepted by both v9dev and v10dev, so this change is forward-compatible regardless of which CDM version is active.Validated with a 4-engine cyclictest run on a kube endpoint:
sum(old behavior): 24860 usec (incorrect — 4x inflated)max(new behavior): 4431 usec (correct — worst engine)avg: 4414 usecmin: 4397 usecTest plan
crucible get resultshows the max value rather than the sum🤖 Generated with Claude Code