Skip to content

fix: skip opensearch init/rebuild on releases where they were removed - #221

Merged
k-rister merged 1 commit into
mainfrom
skip-removed-opensearch-commands
Jun 2, 2026
Merged

fix: skip opensearch init/rebuild on releases where they were removed#221
k-rister merged 1 commit into
mainfrom
skip-removed-opensearch-commands

Conversation

@k-rister

@k-rister k-rister commented Jun 2, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Skip crucible opensearch init and crucible opensearch rebuild CI commands on releases 2025.4+ where these subcommands no longer exist
  • These commands were removed in the multi-opensearch commit (669b00f, release 2025.4) but the CI continued to call them. They silently passed because the old opensearch block in bin/_main had no else clause for unrecognized subcommands
  • The instances-to-services merge (crucible#592) correctly routes unknown subcommands to manage_opensearch.py which rejects them, exposing this latent issue

Test plan

  • Verify crucible#592 CI passes after this fix is merged
  • Verify older release CI (2025.3 and earlier) still runs init/rebuild

🤖 Generated with Claude Code

The opensearch init and rebuild subcommands were removed in the
multi-opensearch commit (669b00f) which shipped in release 2025.4.
The CI was still calling these commands unconditionally, but they
silently did nothing because the old opensearch command block in
bin/_main had no else clause for unrecognized subcommands. The
instances-to-services merge (PR#592) correctly routes unknown
subcommands to manage_opensearch.py which rejects them, exposing
this latent issue.

Scope init/rebuild to releases 2025.3 and earlier where they existed.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@k-rister k-rister self-assigned this Jun 2, 2026
@k-rister
k-rister requested a review from a team June 2, 2026 18:58
@project-crucible-tracking project-crucible-tracking Bot moved this to In Progress in Crucible Tracking Jun 2, 2026
@k-rister
k-rister merged commit 826b65a into main Jun 2, 2026
2166 of 2193 checks passed
@github-project-automation github-project-automation Bot moved this from In Progress to Done in Crucible Tracking Jun 2, 2026
@k-rister
k-rister deleted the skip-removed-opensearch-commands branch June 2, 2026 23:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants