feat: remove deprecated runner-type and runner-tags from CI workflows - #222
Merged
Conversation
The capability-based matching in rickshaw PR#824 replaced the runner-type bifurcation. These parameters are no longer needed — runner pool capabilities and labels are now defined in crucible-ci.json. Also respect endpoint enabled flag in get-endpoints.py. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
atheurer
approved these changes
Jun 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
runner-typeandrunner-tagsparameters from workflow calls toget-job-parametersactionrunner-typeandrunner-tagsinputs as deprecated in the action definition--runner-typeand--runner-tagsfrom thegenerate-ci-jobs.pycommand lineenabledflag inget-endpoints.pyJira
PERFNFV-313
Depends on
Changed files
.github/actions/get-job-parameters/action.yml— deprecated runner-type/runner-tags inputs, removed from command line.github/workflows/endpoint-crucible-ci.yaml— removed runner-type and runner-tags from get-job-parameters call.github/workflows/core-endpoint-crucible-ci.yaml— same.github/actions/get-endpoints/get-endpoints.py— respect endpoint enabled flag from crucible-ci.jsonTest plan
🤖 Generated with Claude Code