feat: add tool-metadata.json and multiplex.json - #7
Conversation
PR Review: tool-mlxreg#7 — feat: add tool-metadata.json and multiplex.jsonSummary: Adds Documentation
File Coverage
LimitationsDid not runtime-test VerdictApprove with comments — the implementation is a clean, schema-compliant match to every sibling tool's reference implementation; the only finding is a non-blocking pre-existing README default-value discrepancy that the author can fix at their discretion. 🤖 Generated with Claude Code |
|
Addressed the review feedback in commit 7be5511:
|
Summary
tool-metadata.json: description and CDM indexing status fortool-mlxreg'smlxregmetric source, enumeratingpower-wattsmetric types and output artifacts (mlxreg-data/<device>.csv.xz,mlxreg-pid.txt,mlxreg-start-stderrout.txt,mlxreg-stop-stderrout.txt).multiplex.json: validations fordevices,sensors, andinterval, plus adefaultspreset reproducingmlxreg-start's bash defaults (sensors="1,2,6,127",interval="2") required for empty parameter sets.crucible tools list(crucible#654 / crucible#655).AGENTS.mdandCLAUDE.md(@AGENTS.md) per the agent instructions convention.Test plan
[✓] Validated
tool-metadata.jsonagainstcrucible/schema/tool-metadata.jsonwithjsonschema.validate()[✓] Validated
multiplex.jsonagainstmultiplex/JSON/req-schema.jsonwithjsonschema.validate()[✓] Live-tested
multiplex.jsonagainstmultiplex.py --flat:[]→defaultspreset backfillssensors="1,2,6,127",interval="2"devices="0000:b5:00.0,0000:c3:00.0",sensors="1,2",interval="5") round-trip unchangedinvalid) correctly rejected withEC_VALIDATIONS_FAIL(rc=4)[✓] Verified syntax of
mlxreg-post-processwithpy_compile.