feat: add tool-metadata.json and multiplex.json - #70
Merged
Conversation
Reference implementation for crucible#653, consumed by `crucible tools list` (crucible#654 / crucible#655). - Adds `tool-metadata.json`: description and CDM-indexed status for the 4 subtools (mpstat, sar, iostat, pidstat), including sar's split into 5 distinct CDM sources by section (sar-mem, sar-io, sar-tasks, sar-scheduler, sar-net) and mpstat's dynamically-forked source name (`mpstat-<fork-index>`). - Adds `multiplex.json`: validation rules for `sysstat-start`'s params plus a `defaults` preset reproducing its own bash defaults (`subtools=mpstat,sar,iostat,pidstat`, `interval=3`) — required so existing `tool-params.json` entries with zero params (a legal, pre-existing case) keep working once this tool opts into rickshaw's multiplex bridge (rickshaw#865). - Updates `CLAUDE.md`'s Key Files table with both new files. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
atheurer
approved these changes
Aug 21, 2026
atheurer
left a comment
atheurer
left a comment
Contributor
There was a problem hiding this comment.
LGTM! Verified schema conformance and metric type definitions against the post-processing scripts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tool-metadata.json: description and CDM-indexed status for the 4 subtools (mpstat, sar, iostat, pidstat), including sar's split into 5 distinct CDM sources by section (sar-mem, sar-io, sar-tasks, sar-scheduler, sar-net) and mpstat's dynamically-forked source name (mpstat-<fork-index>).multiplex.json: validation rules forsysstat-start's params plus adefaultspreset reproducing its own bash defaults (subtools=mpstat,sar,iostat,pidstat,interval=3) — required so existingtool-params.jsonentries with zero params (a legal, pre-existing case) keep working once this tool opts into rickshaw's multiplex bridge (rickshaw#865).crucible tools list(crucible#654 / crucible#655).CLAUDE.md's Key Files table with both new files.Test plan
tool-metadata.jsonagainst the current shipped schema (crucible/schema/tool-metadata.json) withjsonschema.validate()multiplex.jsonagainst the realmultiplex.pybinary:defaultspreset backfillssubtools/interval=3subtools=mpstat,iostat,interval=5) round-trip unchanged0) and invalid subtool name (bogus) both correctly rejected withEC_VALIDATIONS_FAIL🤖 Generated with Claude Code