Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add tests for ping on disconnected handle, issue #306 #319

Merged
merged 2 commits into from
Dec 15, 2019
Merged

add tests for ping on disconnected handle, issue #306 #319

merged 2 commits into from
Dec 15, 2019

Conversation

hashbangperl
Copy link

add tests for ping on disconnected handle, issue #306

@hashbangperl hashbangperl mentioned this pull request Dec 11, 2019
Open
@dveeden
Copy link
Collaborator

dveeden commented Dec 14, 2019 •
edited
Loading

Looks like there is a minor issue, the number of tests needs to be updated.

t/15reconnect.t                       (Wstat: 65280 Tests: 28 Failed: 2)
  Failed tests:  27-28
  Non-zero exit status: 255
  Parse errors: Bad plan.  You planned 26 tests but ran 28.

@hashbangperl
Copy link
Author

bah! too long using done_testing() instead of plans!

@dveeden dveeden merged commit 2a5e607 into perl5-dbi:master Dec 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hashbangperl @dveeden