fix: hb_maps:get defaults and defaults validation#701
Open
charmful0x wants to merge 6 commits intoimpr/secure-actionsfrom
Open
fix: hb_maps:get defaults and defaults validation#701charmful0x wants to merge 6 commits intoimpr/secure-actionsfrom
charmful0x wants to merge 6 commits intoimpr/secure-actionsfrom
Conversation
This was referenced Feb 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
addressed #688 (comment) in a separate PR due to wider scope
TLDR
there was mixed
hb_maps:get/3andhb_maps:get/4usage where someget/3calls passedOptsas the default value instead of using arity 4 -- patched in:dev_pot_test_vectorsdev_mint_mathdev_mint_statsalso added a fail fast
hb_util:safe_int/1wrapper (dev_mint_math:required_int/1) to replace previoushb_util:int/1usage on required numeric fields, so failures now throw typed errors instead of generic crashes (as the get/4 defaults are now correctly in place)tests run: