fix: hb_maps:get/3 misuse - Opts as default#712
Open
charmful0x wants to merge 1 commit intoimpr/schedule-from-gqlfrom
Open
fix: hb_maps:get/3 misuse - Opts as default#712charmful0x wants to merge 1 commit intoimpr/schedule-from-gqlfrom
charmful0x wants to merge 1 commit intoimpr/schedule-from-gqlfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixed
hb_maps:get/3misuse where Opts was passed as default - switched to get/4 with not_found defaultpreviously, missing keys could incorrectly pass validation because get/3 was reutning Opts instead of not_found
i based this PR on the latest active dev_location work branch, is this the preferred base, or should i rebase to edge?