fix: make prometheus metric calls fault-tolerant in hb_http_client#717
Open
Lucifer0x17 wants to merge 1 commit intoneo/edgefrom
Open
fix: make prometheus metric calls fault-tolerant in hb_http_client#717Lucifer0x17 wants to merge 1 commit intoneo/edgefrom
Lucifer0x17 wants to merge 1 commit intoneo/edgefrom
Conversation
When prometheus is running but `init_prometheus()` is not called while running test and then during metric recording race condition occur and calls like prometheus_counter:inc would throw `{error, unknown_metric}` because the metrics were never declared.
This crash propagated up through `hb_store_gateway:read`, which catches exceptions and returns the atom `failure`. Since the store chain only falls through on `not_found`, `failure` stopped the chain -- preventing subsequent stores from being tried and ultimately crashing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When prometheus is running but
init_prometheus()is not called while running test and then during metric recording race condition occur and calls like prometheus_counter:inc would throw{error, unknown_metric}because the metrics were never declared.This crash propagated up through
hb_store_gateway:read, which catches exceptions and returns the atomfailure. Since the store chain only falls through onnot_found,failurestopped the chain -- preventing subsequent stores from being tried and ultimately crashing.